Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove outputs from repository source files, update build scripts #144

Merged
merged 3 commits into from
Jul 24, 2023

Conversation

ttytm
Copy link
Member

@ttytm ttytm commented Jul 21, 2023

This PR removes the build outputs and release files from the repositories source files. It keeps the Makefiles.

Like mentioned in some other places e.g. #114 it's not the preferred way of distributing build and release files.

From #143: "Nightly" pre-compiled builds can be found as release artifacts in the Actions section of the webui repository https://github.com/webui-dev/webui/actions. Similar like they are found on this PR branch action:
https://github.com/webui-dev/webui/actions/runs/5626124981?pr=143

@AlbertShown
Copy link
Contributor

LGTM

@AlbertShown
Copy link
Contributor

"Nightly" pre-compiled builds can be found as release artifacts in the Actions section

Do you mean creating releases daily?

@AlbertShown
Copy link
Contributor

Let's discuss this here.
About this PR, I guess it's good to be merged as we already agreed to remove all pre-built binaries.

@ttytm
Copy link
Member Author

ttytm commented Jul 21, 2023

Let's discuss this here. About this PR, I guess it's good to be merged as we already agreed to remove all pre-built binaries.

Nice, I'm at my phone atm. I'll see later if I can do it else tomorrow if there can be done something with the gitignore file so users get less changes in version control when they run the Makefiles themselves 🙂.

I also need to make a little update to the build.sh files due to the deleted Release directory I noticed.


The necessary files were updated, I'll add a little description to have a better record of what has changed tomorrow.

@ttytm ttytm force-pushed the chore/remove-build-outputs branch from 2790029 to 8f251df Compare July 22, 2023 01:03
@ttytm ttytm changed the title chore: remove build outputs build: remove outputs from repository source files, update build scripts Jul 22, 2023
@ttytm ttytm force-pushed the chore/remove-build-outputs branch from 8f251df to 5131a49 Compare July 22, 2023 01:09
@ttytm ttytm force-pushed the chore/remove-build-outputs branch from 5131a49 to 7eec4ac Compare July 22, 2023 13:20
Copy link
Member Author

@ttytm ttytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next to removing the build outputs the .gitignore file and build scripts were updated.

Now, when the build scripts are executed the compiled files would be put into the dist/ directory - the directory name is commonly used for compiled output files (/dist "distributable", the compiled code/library). It would be created instead of the current Release directory - which was the only directory in the repository root starting with an uppercase letter.

Below I'll add some descriptions to the changes. Please let me know if changes are desired.

build/linux_build.sh Show resolved Hide resolved
build/linux_build.sh Show resolved Hide resolved
build/linux_build.sh Show resolved Hide resolved
@ttytm ttytm requested a review from AlbertShown July 22, 2023 13:58
.gitignore Show resolved Hide resolved
@ttytm
Copy link
Member Author

ttytm commented Jul 23, 2023

What I never asked: Do we even need to keep the build scripts when the releases are made available via GitHub? As they run the Makefiles and compress the outputs in a separate directory, I imagine this mainly helped the maintainers creating the releases. Maybe now it's enough to simplify it and remove the scripts. If there is a need to self-compile, users could still build the versions that fits their needs directly using the related Makefile.

@AlbertShown
Copy link
Contributor

Do we even need to keep the build scripts

We must keep the scripts, as makefile compile the library only. While the build scripts compile the library, copy binaries to all examples folder, copy include files to examples and copy binaries to the dist folder.

@ttytm
Copy link
Member Author

ttytm commented Jul 24, 2023

Thanks for your reply @AlbertShown.

I see that it's good to keep them. The updates that are made to them here can then serve a good purpose as well. I would merge this then, if I may.

@AlbertShown
Copy link
Contributor

LGTM.

@ttytm ttytm merged commit 4d76051 into webui-dev:main Jul 24, 2023
8 checks passed
@ttytm ttytm deleted the chore/remove-build-outputs branch July 24, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants