Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compiling webview shared library on linux #116

Merged
merged 1 commit into from
Jun 25, 2022

Conversation

sigmaSd
Copy link
Contributor

@sigmaSd sigmaSd commented Jun 25, 2022

fix #114

stdout had an extra '\n' that was messing the c++ invocation

Also compiling on two steps doesn't seem to work so I just merged it into one.

@eliassjogreen
Copy link
Member

eliassjogreen commented Jun 25, 2022

Thank you! I can't test this locally but does it work? Im guessing so but just wanted to make sure

@sigmaSd
Copy link
Contributor Author

sigmaSd commented Jun 25, 2022

Yes on my system xD maybe we should just way for more input, @andrewbrey can you give this a try?

@eliassjogreen
Copy link
Member

Hmm, I can gamble and merge to test on CI, if it does not work I will revert and we can try again.

@eliassjogreen eliassjogreen changed the title Fix compiling webview shared library fix: compiling webview shared library on linux Jun 25, 2022
@eliassjogreen eliassjogreen merged commit f7e907b into webview:main Jun 25, 2022
@eliassjogreen
Copy link
Member

Could you try running locally using the latest artifacts?

Set PLUGIN_URL=path/to/extracted/artifacts and then run like normal. Test an example or something just to make sure it works!

@sigmaSd
Copy link
Contributor Author

sigmaSd commented Jun 25, 2022

yep works

@eliassjogreen
Copy link
Member

Alright great! releasing a patch then! Thanks again for your super quick contribution and communication!

@sigmaSd
Copy link
Contributor Author

sigmaSd commented Jun 25, 2022

thanks as well!

@andrewbrey
Copy link

@eliassjogreen and @sigmaSd, just tested the fix locally on v0.7.3 and it's now working correctly! Cheers, and thank you very much for the swift turn-around :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Error undefined symbol: gtk_init_check in .so file on Linux
3 participants