Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix system packages not being found #121

Merged
merged 1 commit into from
Nov 18, 2022

Conversation

wgnf
Copy link
Owner

@wgnf wgnf commented Nov 18, 2022

πŸ“« Addressed Issue(s)

none

πŸ“„ Description

i realized that sometimes System packages are not being considered or found. Added a new cache directory which contains offline packages of an SDK installation which should help.

βœ… Checks

  • My PR adheres to the general code-style of this project (look at other code if you're unsure)
  • [ ] My code requires changes to the documentation
  • [ ] I have updated the documentation as required
  • All the automated tests have passed

@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Merging #121 (c26fefd) into main (61edea0) will decrease coverage by 0.02%.
The diff coverage is 92.85%.

@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
- Coverage   96.98%   96.95%   -0.03%     
==========================================
  Files          54       54              
  Lines        2287     2300      +13     
==========================================
+ Hits         2218     2230      +12     
- Misses         69       70       +1     
Impacted Files Coverage Ξ”
...ore/Liz.Core/Utils/ProvideNugetCacheDirectories.cs 97.72% <92.85%> (-2.28%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@wgnf wgnf merged commit 759e780 into main Nov 18, 2022
@wgnf wgnf deleted the fix/system-packages-not-being-found branch November 18, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant