Skip to content
This repository has been archived by the owner on Sep 2, 2020. It is now read-only.

Second attempt to fix CSS regression. #138

Merged
merged 2 commits into from
May 7, 2018

Conversation

montehurd
Copy link
Collaborator

@montehurd montehurd commented May 5, 2018

6.0.5 (#137) fixed the CSS regression when developing locally, but when 6.0.5 was published the CollapseTable css again jumped above the ThemeTransform css. Based on the information below I suspect extract-text-webpack-plugin is at fault.

So this PR uses mini-css-extract-plugin instead of extract-text-webpack-plugin, per the recommendations in the comments linked below.


How can I keep the css order in the css file when I use extract-text-webpack-plugin?

webpack-contrib/extract-text-webpack-plugin#200

...extract-text-webpack-plugin is for webpack3 and older (will not support webpack 4 it seems). They say to move to mini-css-extract-plugin...

webpack-contrib/extract-text-webpack-plugin#200 (comment)

The webpack >= v4.0.0 'support' for extract-text-webpack-plugin was moved to mini-css-extract-plugin as more lightweight approach for webpack >= v4.0.0 and ETWP entered maintenance mode. We are sorry for the inconvenience here, but ETWP reached a point where maintaining it become too much of a burden and it's not the first time upgrading a major webpack version was complicated and cumbersome due to issues with ETWP. The mid-term plan is integrate CSS support directly into webpack to avoid this kind of issue in the future

webpack-contrib/extract-text-webpack-plugin#701 (comment)

Use `mini-css-extract-plugin` instead of `extract-text-webpack-plugin`.

"How can I keep the css order in the css file when I use extract-text-webpack-plugin"
"TL;DR Use mini-css-extract-plugin instead"
webpack-contrib/extract-text-webpack-plugin#200
webpack-contrib/extract-text-webpack-plugin#200 (comment)
webpack-contrib/extract-text-webpack-plugin#701 (comment)
Copy link
Collaborator

@sharvaniharan sharvaniharan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on Android
bug-fix

@sharvaniharan
Copy link
Collaborator

screen shot 2018-05-07 at 10 35 10 am

baseline at the top too

@sharvaniharan sharvaniharan merged commit ae51155 into master May 7, 2018
@sharvaniharan sharvaniharan deleted the fix/css-regression-take-two branch May 7, 2018 17:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants