Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WFLY-14559: Updated WFLY-14559_Add_six_new_RESTEasy_context_parameter… #562

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ronsigal
Copy link
Contributor

@ronsigal ronsigal commented Mar 22, 2024

…s.adoc

This is a copy of #560, which, somehow, I closed. I've copied all of the relevant comments and responded to them.

@ronsigal
Copy link
Contributor Author

  • {issue-base-url}/RESTEASY-2280[RESTEASY-2280]
  • {issue-base-url}/RESTEASY-2646[RESTEASY-2646]
  • {issue-base-url}/RESTEASY-2782[RESTEASY-2782]
  • {issue-base-url}/RESTEASY-2849[RESTEASY-2849]
  • {issue-base-url}/RESTEASY-2866[RESTEASY-2866]

"Minor nit, this should just be https://issues.redhat.com/browse. We migrated away from the issue-base-url for ease of copy/paste when reviewing."

Done

@ronsigal
Copy link
Contributor Author

  • resteasy.match.cache.enabled: [RESTEASY-2646]
  • resteasy.match.cache.size: [RESTEASY-2646]
  • resteasy.original.webapplicationexception.behavior: [RESTEASY-2782]
  • resteasy.patch.filter.disabled: [RESTEASY-2280]
  • resteasy.patch.filter.legacy: [RESTEASY-2849]
  • resteasy.proxy.implement.all.interfaces: [RESTEASY-2866]

"Should we drop the resteasy prefix from the model attribute names? I know most of them have that prefix now, but it's not strictly required and saves some typing for administators."

I made a comment on wildfly/wildfly#17742: "What if we add a shortened version of every parameter, all at one time, in a new feature request. Then the old names work and each has a shortened version as well."

@ronsigal
Copy link
Contributor Author

The wildfly/jaxrs module should be extended to expose these new parameters.

"s/wildfly/WildFly for consistency with other references."

In places where I wrote "wildfly/jaxrs", I'm referring to the code at https://github.com/wildfly/wildfly/tree/main/jaxrs. WDYT?

@ronsigal
Copy link
Contributor Author

  • resteasy.original.webapplicationexception.behavior:

    testsuite/integration-tests/src/test/java/org/jboss/resteasy/test/client/exception/ClientWebApplicationExceptionMicroProfileProxyTest.java

"Should these be links? I'm not convinced they should be, but it seems like we could easily enough make them links to the source"

I updated them to be links. I would add links to the WildFly tests, but the new ones haven't been pulled in yet. Can I update this document after wildfly/wildfly#17742 is merged?

@ronsigal
Copy link
Contributor Author

"Please add the jekyll front matter (the categories stuff)."

Done

@ronsigal
Copy link
Contributor Author

  • {issue-base-url}/EAP7-1655[EAP7-1655]

"Nit: this is a related issue; this does not directly address EAP7-1655."

I moved it to Related Issues.

@ronsigal
Copy link
Contributor Author

"Please add the Stability section."

In an email, @jamezp said, "I don't think we need to worry about the experimental stuff at this point.", so I set it to "default", but I can change that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant