-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal to update WildFly download distributions using channels #577
base: main
Are you sure you want to change the base?
Conversation
@bstansberry @spyrkob This proposal would encompass https://issues.redhat.com/browse/WFLY-19221 but I'd like to get the whole user story in the proposal (including the tooling aspect of it). |
4. Run a script in the existing WildFly installation to update if from x.y.z to x.y.(z+1) | ||
5. Reload the server to run your applications on WildFly x.y.(z+ 1) | ||
|
||
If there are multiple available updates for WildFly, the user must be able to decide which one they want to update to. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note - that would be a new requirement for prospero, not something that is currently supported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as a note, it is possible to decide to which version to update by changing the manifest.maven.version
in .installation/installer-channels.yaml
to point to a new manifest
|
||
=== Default Configuration | ||
|
||
Updating an installation could update its default configuration (eg if the update is to a major version). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently Galleon (and consequently Prospero) will only update default configurations if there are no user changes in that configuration file. Any changes are recorded in a .new
file and it's up to the user to merged those.
Is this the expected behaviour or are we going to try to merge the user changes with upcoming changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The existing behaviour is suitable. We would then need to drive the user to review the changes and apply them before reloading their server. wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding reloading - the changes to the server have to applied while the server is down, so it's a case of starting the server again rather than reloading.
Right now prospero should display a list of such conflicts at the end of update and let the user know they might need to merge those themselves.
Thanks for this, @jmesnil. This goes well beyond WFLY-19221, which is a good thing. But it goes beyond in ways that seem unlikely to be completed by the June 26 feature freeze for WildFly 33. So I'm not sure what we (e.g. me, you, @spyrkob) want to do re WF 33. WFLY-19221 itself establishes a kind of new contract for WF, e.g. that in our download zips there will be files in certain locations with certain content. (We somewhat already have contracts in this regard as we publish manifests that tools like wildfly-maven-plugin can use.) If we know enough about what that contract should be, perhaps we can do something re WFLY-19221 in 33. If not, we shouldn't. I don't think that right now we know enough, because the use case discussion here may affect things. OTOH, if there's significant value in having WFLY-19221 in 33 (e.g. to provide a base for other tooling development) it might be the case that we'd know enough a couple weeks from now, if we make that a goal of the discussion. |
Signed-off-by: Jeff Mesnil <[email protected]>
Signed-off-by: Jeff Mesnil <[email protected]>
Signed-off-by: Jeff Mesnil <[email protected]>
bf87858
to
502123e
Compare
I update the proposal to address some of the questions you raise. For WildFly 33, I agree that we will not be able to address the tooling aspect of the proposal. The only advantage of having WFLY-19221 done for WildFly 33 is to be able to work incrementally and that it leaves us the full dev cycle of 34 to address the tooling aspect. That's a weak argument so if @bstansberry or @spyrkob, you don't see another value for WFLY-19221 in itself, let's move it to WildFly 34 and do the tooling at the same time. |
No description provided.