Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor sitemap: better typings #3634

Merged
merged 1 commit into from
Jun 20, 2022

Conversation

alextim
Copy link
Contributor

@alextim alextim commented Jun 18, 2022

Changes

  • Typings
    • serialize - sync/async func should return SitemapItem | Promise<SitemapItem>;
    • use SitemapItem type instead of SitemapItemLoose;
    • 'changefreq' option - use EnumChangefreq` from the sitemapjs pkg instead of self made constants (DRY).
  • Few corrections in README.md.

Testing

locally

@changeset-bot
Copy link

changeset-bot bot commented Jun 18, 2022

⚠️ No Changeset found

Latest commit: fc0ad79

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Jun 18, 2022
@alextim alextim changed the title refactor: better typings refactor sitemap: better typings Jun 18, 2022
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, thank you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants