Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly catch falsey components #3650

Merged
merged 1 commit into from
Jun 20, 2022
Merged

Properly catch falsey components #3650

merged 1 commit into from
Jun 20, 2022

Conversation

natemoo-re
Copy link
Member

Changes

  • Fixes issue with bad error message reported on Discord
  • We were not catching undefined components and throwing an error as expected.

Testing

N/A

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Jun 20, 2022

🦋 Changeset detected

Latest commit: b8bd6a1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jun 20, 2022
Copy link
Contributor

@tony-sull tony-sull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@natemoo-re natemoo-re merged commit d9f6dcf into main Jun 20, 2022
@natemoo-re natemoo-re deleted the fix/undefined-renderer branch June 20, 2022 19:14
@github-actions github-actions bot mentioned this pull request Jun 20, 2022
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants