Check null for props serialization #3657

leaysgur · 2022-06-21T12:15:15Z

Changes

Currently, astro build fails with client-hydrated-component like below.

---
import Counter from '../components/Counter.tsx';
---
<html lang="en">
	<head>
		<meta charset="utf-8" />
	</head>
	<body>
		<main>
			<Counter client:visible data={{ x: null }} />
		</main>
	</body>
</html>

Because typeof null === object,

astro/packages/astro/src/runtime/server/serialize.ts

Lines 50 to 52 in 411af7a

    
           default: { 
        
           	if (typeof value === 'object') { 
        
           		return [PROP_TYPE.Value, serializeObject(value)];

and Object.entries(null) throws.

astro/packages/astro/src/runtime/server/serialize.ts

Lines 18 to 24 in 411af7a

    
           function serializeObject(value: Record<any, any>): Record<any, any> { 
        
           	return Object.fromEntries( 
        
           		Object.entries(value).map(([k, v]) => { 
        
           			return [k, convertToSerializedForm(v)]; 
        
           		}) 
        
           	); 
        
           }

Previously(#3571), serialize-javascript had covered this scenario.

Testing

I'd like to add some tests, but where should it be placed...?

Docs

Nothing changed.

changeset-bot · 2022-06-21T12:15:20Z

🦋 Changeset detected

Latest commit: 3c83d8b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
astro	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

natemoo-re

LGTM! Thanks for the fix!

* Check null for props serialization * Add changeset

Yuji Sugiura and others added 2 commits June 21, 2022 20:52

Check null for props serialization

bee21ae

Add changeset

3c83d8b

github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jun 21, 2022

natemoo-re requested a review from matthewp June 21, 2022 13:38

natemoo-re approved these changes Jun 21, 2022

View reviewed changes

natemoo-re merged commit 7d4699b into withastro:main Jun 21, 2022

github-actions bot mentioned this pull request Jun 21, 2022

[ci] release #3662

Merged

leaysgur deleted the patch-1 branch June 21, 2022 22:13

SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023

Check null for props serialization (withastro#3657)

920f4d3

* Check null for props serialization * Add changeset

snyk-io bot mentioned this pull request May 21, 2024

[Snyk] Upgrade esbuild from 0.19.12 to 0.20.2 Hawthorne001/astro#3

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Check null for props serialization #3657

Check null for props serialization #3657

leaysgur commented Jun 21, 2022 •

edited

Loading

changeset-bot bot commented Jun 21, 2022

natemoo-re left a comment

	default: {
	if (typeof value === 'object') {
	return [PROP_TYPE.Value, serializeObject(value)];

	function serializeObject(value: Record<any, any>): Record<any, any> {
	return Object.fromEntries(
	Object.entries(value).map(([k, v]) => {
	return [k, convertToSerializedForm(v)];
	})
	);
	}

Check null for props serialization #3657

Check null for props serialization #3657

Conversation

leaysgur commented Jun 21, 2022 • edited Loading

Changes

Testing

Docs

changeset-bot bot commented Jun 21, 2022

🦋 Changeset detected

natemoo-re left a comment

Choose a reason for hiding this comment

leaysgur commented Jun 21, 2022 •

edited

Loading