Add eslint config, run it in ci for bot.js #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The entire bot is basically built on runtime requiring of dynamically determined strings.
In the future this should lint all javascript, but this is what we've got for now.
brhoades
reviewed
Nov 18, 2017
brhoades
approved these changes
Nov 18, 2017
|
I'm not familiar with Travis, but if it passes eslint isn't working right ;). |
brhoades
requested changes
Nov 18, 2017
| "mocha": "^2.5.3", | ||
| "sinon": "^2.3.6" | ||
| }, | ||
| "scripts": { | ||
| "start": "node --max_old_space_size=350 index.js", | ||
| "install": "./installModules.sh", | ||
| "test": "mocha $(git ls-files | grep -E \"test.js$\")" | ||
| "test": "mocha $(git ls-files | grep -E \"test.js$\")", | ||
| "lint": "eslint bot.js" |
There was a problem hiding this comment.
Just saw this.
eslint --ignore-pattern node_modules *.js modules/**/*.js
There was a problem hiding this comment.
I'd like to move to that, but I'd rather have it run on the files it passes on for now and add the remaining files later.
Incrementally adding which files it lints allows us to get some signal from travis for some changes without having to fixup everything yet (which I'm not up to at the moment).
brhoades
approved these changes
Nov 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's still a long way to go before we can run this on the whole thing, but this is a start.
@brhoades, want to take a look?