Report UART status as events; addl UART events #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is more flexible & allows for multiple listeners. The new events allow the user to push data to the UART without a ton of trouble & setTimeouts.
|
I guess this is really two proposals in one?
I'd be interested to hear what you think of them, and if you think this is a good direction to go in at all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more flexible & allows for multiple listeners.
The new events allow the user to push data to the UART without a ton of trouble & setTimeouts.
This does introduce a new dependency,
eventemitter3. This is not really needed for Node, but it is needed on the browser since the browser's events implementation is different than in Node.