-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1단계 - 블랙잭 게임 실행] 구름(김민수) 미션 제출합니다. #606
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 누락된 요구사항을 추가했다. - 기존 구현 기능 목록을 정리했다. - 구현 기능을 체크했다. - 누락된 도메인 용어를 추가했다.
- 누락된 요구사항을 추가했다. - 구현 기능을 체크했다.
- 구현 기능을 체크했다. - 누락된 요구사항 추가했다. - 누락된 도메인 용어를 정리했다.
summerlunaa
approved these changes
Mar 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
구름 안녕하세요~ 블랙잭 리뷰어 파랑입니다 🐳
블랙잭 1단계 미션을 잘 구현하셨네요! 👏 아쉽지만 리뷰 요청 시간을 넘겨서 리뷰 없이 머지하겠습니다.
2단계 바로 진행해주세요~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요. 파랑! 구름 입니다!
이번에는 아톰이랑 페어를 해봤어요~
아주 작은 단위로 TDD를 하고, 당장 사용하지 않는 것들을 만들지 않고 개발했습니다.
확실히 시간이 오래 걸리긴 했지만, 불필요한 코드 없이 개발할 수 있었습니다.
리뷰 잘 부탁드립니다 :)