Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code search close button issues #959

Closed
UrtsiSantsi opened this issue Jul 4, 2024 · 0 comments · Fixed by #960
Closed

Code search close button issues #959

UrtsiSantsi opened this issue Jul 4, 2024 · 0 comments · Fixed by #960
Milestone
46.2

Comments

@UrtsiSantsi
Copy link
Contributor

There are 2 issues:

  1. Closing the code search using the close button doesn't clear the highlights in the code
  2. Next time the search is opened it is empty instead of using the last searched word
UrtsiSantsi added a commit that referenced this issue Jul 4, 2024
@UrtsiSantsi
Fix code search close button behavior (#959)
23dc6f3 
Clear the highlights in the code and remember the last searched word
UrtsiSantsi added a commit that referenced this issue Jul 8, 2024
@UrtsiSantsi
Fix code search close button behavior (#959)
4691e96 
Clear the highlights in the code and remember the last searched word
@sonnyp sonnyp mentioned this issue Jul 10, 2024
Merged
@sonnyp sonnyp closed this as completed in fa3f77e Jul 10, 2024
@sonnyp sonnyp added this to the 46.2 milestone Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
46.2
Development

Successfully merging a pull request may close this issue.

Fix code search close button behavior workbenchdev/Workbench
2 participants
@sonnyp @UrtsiSantsi