Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typechecking with JavaScript #972

Merged
merged 3 commits into from
Jul 14, 2024
Merged

Typechecking with JavaScript #972

merged 3 commits into from
Jul 14, 2024

Conversation

vixalien
Copy link
Contributor

Using the world-famous jsconfig.json

image

@vixalien vixalien requested a review from sonnyp as a code owner July 14, 2024 16:04
sonnyp
sonnyp approved these changes Jul 14, 2024
View reviewed changes
Copy link
Contributor

@sonnyp sonnyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing because the JS formatter now produces a different output

we can't fix it here - I'll make a follow up

@sonnyp sonnyp merged commit 3a8e52c into main Jul 14, 2024
1 check failed
@sonnyp sonnyp deleted the wip/vixalien/jschecking branch July 14, 2024 18:52
@sonnyp sonnyp mentioned this pull request Jul 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonnyp sonnyp sonnyp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vixalien @sonnyp