Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue with global environment CU-8677zdvv4 #63

Open
wants to merge 15 commits into
base: DEV
Choose a base branch
from

Conversation

randrescastaneda
Copy link
Collaborator

@randrescastaneda randrescastaneda commented May 2, 2023

Hi @tonyfujs,

I think this PR is ready to merge. It solves the issue of the caching. The only thing that is missing is the ability to turn the caching on or off. I just thought about it. I don't think that is super important, either is it too difficult to implement. @shahronak47 , could you please take a look and let me know?

Thanks.
Best,

image

Copy link
Contributor

@shahronak47 shahronak47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @randrescastaneda , I just added a couple of trivial suggestions

R/aaa.R Outdated
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
## Evaluate if exists --------

to_set <- 1
if (rlang::env_has(.pip, table)) {
if (force == FALSE) {
if (replace == FALSE) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use isFALSE function here as we do it at other places?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Yes

R/utils.R Outdated
#'
#' @return data frame with new names
#' @keywords internal
renamecols <- function(df, oldnames, newnames) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the name to rename_cols for consistency with other functions in the package ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Good idea.

@randrescastaneda
Copy link
Collaborator Author

Hi @randrescastaneda , I just added a couple of trivial suggestions

Hi @shahronak47 , good suggestions. Could you please implement them? I can't right now. If you can't, I'll do it in a few hours. Thanks!

@randrescastaneda
Copy link
Collaborator Author

Hi @randrescastaneda , I just added a couple of trivial suggestions

HI Ronak. I just implemented your suggestions.
Thanks.
Best.

@randrescastaneda randrescastaneda changed the title fix issue with global envoronment fix issue with global environment CU-8677zdvv4 May 10, 2023
@randrescastaneda randrescastaneda changed the title fix issue with global environment CU-8677zdvv4 fix issue with global environment #8677zdvv4 May 10, 2023
@randrescastaneda randrescastaneda changed the title fix issue with global environment #8677zdvv4 fix issue with global environment CU-8677zdvv4 May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants