Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bash and sh default config #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

keydon3
Copy link

@keydon3 keydon3 commented Oct 6, 2022

Just added bash and sh in default config

@wtetsu
Copy link
Owner

wtetsu commented Oct 8, 2022

Hi,
thank you for your contribution.

However, not including shell script in the default settings is intentional design in order to avoid accident.
Shell script can contain destructive operations easily, besides it's known that to modify running shell scripts causes unexpected results.

As you may already know, it is easy to create your own local configuration (~/.gaze.yml)

https://github.com/wtetsu/gaze#configuration

@keydon3
Copy link
Author

keydon3 commented Oct 12, 2022

Of course, awry written shell scripts can lead to problems, but in general this applies to any other badly written scripts and binaries as well.
Perhaps your decision will have a positive effect on the reputation of the project because a few stupid monkeys will not shoot themselves in the foot. But I would prefer to focus on thinking people. I think most of them will have to change the config. Perhaps adding a warning to the README is sufficient.
In any case, this is your project and you are boss here.

@wtetsu wtetsu force-pushed the master branch 2 times, most recently from faf50af to f822ae6 Compare April 29, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants