Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mac] Autoresizing implementation #630

Closed
wants to merge 2 commits into from
Closed

Conversation

CartBlanche
Copy link
Contributor

@CartBlanche CartBlanche commented Sep 16, 2019

Screen Shot 2019-10-10 at 20 40 54

@CartBlanche CartBlanche self-assigned this Sep 16, 2019
@CartBlanche CartBlanche force-pushed the dominique-autoresizing branch 3 times, most recently from 01c0da2 to 7a8807e Compare September 20, 2019 16:37
@CartBlanche
Copy link
Contributor Author

@viniciusjarina & @chkn This is the port of the Autoresizing control into proppy. Could you please look over it and the video I posted on Slack in #proppy (https://xamarinhq.slack.com/archives/C5GBTFXL0/p1568909239055500). It Supports theming and keyboard navigation (Left and Right arrows to cycle through the flags). With theming we need to decide what the actual colour scheme will be between dark and light, but that should be easily changed once we finalise what that will actually be.

@ermau
Copy link
Member

ermau commented Sep 20, 2019

@CartBlanche Theming is here #616 (comment)

@CartBlanche CartBlanche force-pushed the dominique-autoresizing branch 2 times, most recently from bb08971 to bec195b Compare September 26, 2019 09:54
@ermau
Copy link
Member

ermau commented Oct 4, 2019

You'll want to rebase this and use the rectangle sizing methodology now present in the view model as it is more correct.

@CartBlanche CartBlanche force-pushed the dominique-autoresizing branch 4 times, most recently from e8e7f7d to 8b766e7 Compare October 6, 2019 16:58
@CartBlanche
Copy link
Contributor Author

@ermau just to be clear, you are referring to VM.GetPreviewElementRectangle?

@ermau
Copy link
Member

ermau commented Oct 7, 2019

@CartBlanche Correct.

@CartBlanche CartBlanche force-pushed the dominique-autoresizing branch 3 times, most recently from a233c12 to 592c5d3 Compare October 10, 2019 19:39
@CartBlanche CartBlanche marked this pull request as ready for review October 13, 2019 11:33
@CartBlanche
Copy link
Contributor Author

I made it a vertical alignment as it really is better aesthetically than the horizontal one that doesn't support resizing. We can always revisit the alignment, should Forms be needed.

@ermau ermau removed their assignment May 26, 2020
@CartBlanche CartBlanche removed the request for review from ermau August 19, 2020 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants