-
Notifications
You must be signed in to change notification settings - Fork 507
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[bgen] Adjust logic to handle protocol-backed events. (#19689)
Previously we used the presence of the [Protocolize] attribute to detect Delegate properties returning protocols that should be specially handled if the delegate in question supported events (in particular the Delegate property would get additional code to ensure the developer didn't use both the event pattern and the delegate pattern, because then one or the other wouldn't work properly). However, the presence of the [Protocolize] attribute does not take into account that there's another way to declare that a Delegate property uses a protocol: the property could use the protocol directly as the property type, without a [Protocolize] attribute. So change the logic to detect either the [Protocolize] attribute or an actual protocol. This is a slight breaking change in that we'll now add the special code to more Delegate properties, and we'll throw an exception if the developer uses both the event pattern and the delegate pattern in more cases. In theory this should be a good thing (we're detecting more broken developer code), and if it turns out to be an incorrect check, developers can opt out of this extra check anyway.
- Loading branch information
1 parent
44a2da0
commit 2bd2338
Showing
1 changed file
with
15 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
Sorry, something went wrong.