Skip to content

Commit

Permalink
[msbuild] Merge the WriteAppManifest[TaskBase] classes. (#19921)
Browse files Browse the repository at this point in the history
  • Loading branch information
rolfbjarne committed Jan 29, 2024
1 parent a0b92cf commit 9115b35
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 32 deletions.
31 changes: 0 additions & 31 deletions msbuild/Xamarin.MacDev.Tasks/Tasks/WriteAppManifest.cs

This file was deleted.

19 changes: 18 additions & 1 deletion msbuild/Xamarin.MacDev.Tasks/Tasks/WriteAppManifestTaskBase.cs
Original file line number Diff line number Diff line change
@@ -1,15 +1,17 @@
#nullable enable

using System;
using System.Collections.Generic;
using System.IO;
using System.Linq;

using Microsoft.Build.Framework;

using Xamarin.Localization.MSBuild;
using Xamarin.Messaging.Build.Client;

namespace Xamarin.MacDev.Tasks {
public abstract class WriteAppManifestTaskBase : XamarinTask {
public class WriteAppManifest : XamarinTask, ICancelableTask, ITaskCallback {
#region Inputs

[Required]
Expand All @@ -23,6 +25,9 @@ public abstract class WriteAppManifestTaskBase : XamarinTask {

public override bool Execute ()
{
if (ShouldExecuteRemotely ())
return new TaskRunner (SessionId, BuildEngine4).RunAsync (this).Result;

PDictionary plist;

var firstManifest = AppManifests! [0].ItemSpec;
Expand All @@ -47,5 +52,17 @@ public override bool Execute ()

return !Log.HasLoggedErrors;
}

public bool ShouldCopyToBuildServer (ITaskItem item) => false;

public bool ShouldCreateOutputFile (ITaskItem item) => false;

public IEnumerable<ITaskItem> GetAdditionalItemsToBeCopied () => Enumerable.Empty<ITaskItem> ();

public void Cancel ()
{
if (ShouldExecuteRemotely ())
BuildConnection.CancelAsync (BuildEngine4).Wait ();
}
}
}

3 comments on commit 9115b35

@vs-mobiletools-engineering-service2

This comment was marked as outdated.

@vs-mobiletools-engineering-service2

This comment was marked as outdated.

@vs-mobiletools-engineering-service2

This comment was marked as outdated.

Please sign in to comment.