-
Notifications
You must be signed in to change notification settings - Fork 507
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[msbuild] Remove usage of GitInfo in Xamarin.Messaging.Build. (#19935)
* The calculation GitInfo does is horribly wrong for us - it seems to pick a tag the most recent tag and parse it to pick out a version number: * This means for any given release it'll use the previous tag - because we don't necessarily tag until after the release build has been committed. * It's not a stable version: a build is made (finding one tag), a new tag is pushed, and if the same commit is built, it may find the new tag, thus creating a new version number. * We may have multiple tags for any given commit. * The version calculation is also wrong: right now it finds the tag `xamarin-ios-15.5.0.5-4407-gd45f4e90a6`, and comes up with the version number 0.5.0.4407. * I didn't investigate deeply, but GitInfo also touches .git/index and .git/HEAD somehow, which causes us to rebuild stuff. * We already have an established way of calculating version numbers and other build related information, so use that after extending it a bit.
- Loading branch information
1 parent
15c2d80
commit d199292
Showing
3 changed files
with
8 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
Sorry, something went wrong.