[CoreHaptics] Add support for Xcode13 beta1. #11963
Conversation
mandel-macaque
added
the
note-highlight
|
@spouliot locally I have the following when running xtro: Yet we have:
Files are added in mac (else all the other will fail) and the other platforms pick the fields correctly from the keys of the strong dict. Any ideas? |
| @@ -373,6 +377,8 @@ partial interface CHHapticPatternDefinition { | |||
| NSObject WeakParameterCurve { get; set; } | |||
| [Export ("ParameterCurveControlPointsKey")] | |||
| NSObject WeakParameterCurveControlPoints { get; set; } | |||
| [Advice ("The default value is true.")] | |||
| bool EventWaveformUseVolumeEnvelope { get; set; } | |||
There was a problem hiding this comment.
hmm... is this only used as an output ?
because if it's an output then, when created, the value will be false
This can be bound as bool? if the default can (or should) be ignore
There was a problem hiding this comment.
You need to copy the availability [TV (15,0), NoWatch, Mac (12,0), iOS (15,0), MacCatalyst (15,0)]
since this is the public API developers will be using (they keys being internal)
| partial interface CHHapticAudioResourceDefinition { | ||
| [Advice ("The default value is true.")] | ||
| bool UseVolumeEnvelope { get; set; } |
There was a problem hiding this comment.
same as above, better use bool? to let developers not change the default
There was a problem hiding this comment.
So this is backed by a NSDictionary, AFAIK if they do nothing, the key should not be added. But We can do a bool?
There was a problem hiding this comment.
error BI1033: bgen: Limitation: can not automatically create strongly typed dictionary for (System.Nullable`1[System.Boolean]) the value type of the CoreHaptics.CHHapticPatternDefinition.EventWaveformUseVolumeEnvelope property
There was a problem hiding this comment.
hmm... is that not a NSNumber backed bool ?
There was a problem hiding this comment.
@dalexsoto why are we not able to do nullable? Do we need to fix that?
There was a problem hiding this comment.
Please leave your message after the tone. beep... Yeah docs says nothing about nullable types so probably are not supported.
There was a problem hiding this comment.
Already supported as per the API diff:
public class CHHapticAudioResourceDefinition : Foundation.DictionaryContainer {
// constructors
public CHHapticAudioResourceDefinition ();
public CHHapticAudioResourceDefinition (Foundation.NSDictionary dictionary);
// properties
public bool? UseVolumeEnvelope { get; set; }
}
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results1 tests failed, 85 tests passed.Failed tests
Pipeline on Agent XAMBOT-1094.BigSur' |
No description provided.