[CoreLocation] Add xcode13 beta 1 support. #11965
Conversation
mandel-macaque
added
the
note-highlight
src/corelocation.cs
Outdated
| @@ -871,4 +890,19 @@ interface CLBeaconIdentityConstraint : NSCopying, NSSecureCoding { | |||
| [BindAs (typeof (short?))] | |||
| NSNumber Minor { get; } | |||
| } | |||
|
|
|||
| [Model] | |||
There was a problem hiding this comment.
It's unclear how this protocol is supposed to be used, if it's a *Delegate type somewhere or not (it doesn't seem to show up anywhere else in the API).
In the meantime, I think we can remove the [Model] attribute, just in case it's not a *Delegate type. It's easier to add it later than to remove it.
There was a problem hiding this comment.
I added model due to the documentation from the method that the protocol has:
+// Called just before this extension is terminated by the system.
But I'll remove, since it can be re-added.
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results2 tests failed, 84 tests passed.Failed tests
Pipeline on Agent XAMBOT-1104.BigSur' |
src/corelocation.cs
Outdated
| @@ -431,6 +441,15 @@ partial interface CLLocationManager { | |||
| [Export ("authorizedForWidgetUpdates")] | |||
| bool IsAuthorizedForWidgetUpdates { [Bind ("isAuthorizedForWidgetUpdates")] get; } | |||
|
|
|||
| [Async] | |||
| [Watch (8,0), TV (15,0), Mac (12,0), iOS (15, 0)] | |||
There was a problem hiding this comment.
Missing Catalyst. It's not excluded on type-level so it must be annotated for new API.
src/corelocation.cs
Outdated
| [Export ("startMonitoringLocationPushesWithCompletion:")] | ||
| void StartMonitoringLocationPushes ([NullAllowed] Action<NSData, NSError> completion); | ||
|
|
||
| [Watch (8,0), TV (15,0), Mac (12,0), iOS (15, 0)] |
There was a problem hiding this comment.
Missing Catalyst. It's not excluded on type-level so it must be annotated for new API.
src/corelocation.cs
Outdated
| [Model] | ||
| [iOS (15,0), TV (15,0), MacCatalyst (15,0), Mac (12,0), Watch (8,0)] | ||
| [Protocol] | ||
| [BaseType (typeof(NSObject))] |
There was a problem hiding this comment.
remember to remove the [BaseType] when removing the [Model]
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results1 tests failed, 85 tests passed.Failed tests
Pipeline on Agent XAMBOT-1098.BigSur' |
No description provided.