[PDFKit] Updating Xcode13 Beta 1 #11987
Conversation
tj-devel709
added
the
note-highlight
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results1 tests failed, 85 tests passed.Failed tests
Pipeline on Agent XAMBOT-1104.BigSur' |
There was a problem hiding this comment.
Wasn't sure if the PdfAccessPermissions type should be ulong.
Sharpie gave it the ulong type and used the (1uL << #) but the original header used NSUInteger which according to this should be nuint
ulong is correct. We'd like to use nuint, but we can't do that for enums, C# doesn't allow it (only [s]byte, [u]short, [u]int and [u]long are allowed as base types for enums), so we go with the second best option: the 64-bit type. It's the correct type for 64-bit platforms (which will one day be all platforms), and then we add the [Native] attribute to tell the generator and our runtime that it should be treated as a 32-bit value on 32-bit platforms.
src/pdfkit.cs
Outdated
|
|
||
| [iOS (15,0), Mac (12,0), MacCatalyst (15,0)] | ||
| [Field ("PDFDocumentAccessPermissionsOption")] | ||
| NSString AccessPermissionsOption { get; } |
There was a problem hiding this comment.
that last field should with inside PdfDocumentWriteOptionKeys
the hint is that the previous fields (in the headers) are similarly named and (in binding files) already grouped into their own type
There was a problem hiding this comment.
and also update the PdfDocumentWriteOptions strong dictionary :)
There was a problem hiding this comment.
@spouliot I added PDFDocumentAccessPermissionsOption to PdfDocumentWriteOptionKeys and PdfDocumentWriteOptions. I followed along with the pattern of the other elements in there, but not sure why the "+PDFKit" is there or if I needed to add that.
There was a problem hiding this comment.
Oops forgot to run tests, I'll do that now
There was a problem hiding this comment.
Okay the tests look good!
| @@ -434,6 +438,7 @@ interface PdfDocumentWriteOptions { | |||
|
|
|||
| string OwnerPassword { get; set; } | |||
| string UserPassword { get; set; } | |||
There was a problem hiding this comment.
Is missing the availability attrs which should be the same as those of the key.
There was a problem hiding this comment.
without them the developer won't know they are not available (since the keys are not public)
and they (internal) keys also needs them otherwise introspection would not be able to do its job :)
✅ [PR Build] Tests passed on Build. ✅Tests passed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): 🎉 All 86 tests passed 🎉Pipeline on Agent XAMBOT-1096.BigSur' |
Wasn't sure if the PdfAccessPermissions type should be ulong.
Sharpie gave it the ulong type and used the
(1uL << #)but the original header used NSUInteger which according to this should benuint