[GameController] Updates for Xcode13 beta1 #12014
Conversation
tj-devel709
added
the
note-highlight
|
|
||
| [NoTV, NoMac, NoWatch, iOS (15,0), MacCatalyst (15,0)] | ||
| [BaseType (typeof (NSObject))] | ||
| [DisableDefaultCtor] |
There was a problem hiding this comment.
@rolfbjarne I know you already reviewed this PR but I just wanted to make sure that this line is correct. Also for others reviewing later:
I added this since there didn't appear to be an initializer for this interface and we have the virtualControllerWithConfiguration: that creates an instance
There was a problem hiding this comment.
Yes, this looks entirely correct!
Also, if in doubt, it's better to put this attribute than to not to, because we can always add the default ctor later (but we can't remove it once we've made it a part of the stable API).
There was a problem hiding this comment.
Okay thank you!
✅ [PR Build] Tests passed on Build. ✅Tests passed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): 🎉 All 86 tests passed 🎉Pipeline on Agent XAMBOT-1104.BigSur' |
|
@mandel-macaque Updated! |
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffGitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results2 tests failed, 84 tests passed.Failed tests
Pipeline on Agent XAMBOT-1094.BigSur' |
No description provided.