Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GameKit] Updates for Xcode13 Beta 1-2 #12091

Merged
merged 6 commits into from
Jul 13, 2021
Merged

[GameKit] Updates for Xcode13 Beta 1-2 #12091

merged 6 commits into from
Jul 13, 2021

Conversation

tj-devel709
Copy link
Contributor

No description provided.

@tj-devel709 tj-devel709 added the note-highlight Worth calling out specifically in release notes label Jul 8, 2021
@tj-devel709 tj-devel709 added this to the xcode13.0 milestone Jul 8, 2021
@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 85 tests passed.

Failed tests

  • Cecil-based tests/NUnit: Failed (Execution failed with exit code 6)

Pipeline on Agent XAMBOT-1100.BigSur'
Merge 4dfbbad into 9d31e45

mandel-macaque
mandel-macaque requested changes Jul 9, 2021
View reviewed changes
src/gamekit.cs Outdated Show resolved Hide resolved
@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 85 tests passed.

Failed tests

  • Cecil-based tests/NUnit: Failed (Execution failed with exit code 6)

Pipeline on Agent XAMBOT-1094.BigSur'
Merge a7c9099 into 797a2f5

@mandel-macaque
Copy link
Member

@tj-devel709 do not merge until the cecil tests pass.

rolfbjarne
rolfbjarne requested changes Jul 12, 2021
View reviewed changes
src/GameKit/GameKit.cs Outdated Show resolved Hide resolved
src/gamekit.cs Outdated Show resolved Hide resolved
@tj-devel709 tj-devel709 added the do-not-merge Do not merge this pull request label Jul 12, 2021
@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 Tests failed catastrophically on Build (no summary found). 🔥

Result file $(TEST_SUMMARY_PATH) not found.

Pipeline on Agent
Merge 9cf9ac0 into 26a8abe

@tj-devel709
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build] Tests passed on Build. ✅

Tests passed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

🎉 All 86 tests passed 🎉

Pipeline on Agent XAMBOT-1104.BigSur'
Merge 8cda52f into 26a8abe

@tj-devel709 tj-devel709 removed the do-not-merge Do not merge this pull request label Jul 13, 2021
@tj-devel709 tj-devel709 merged commit ecd8dcc into xamarin:main Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolfbjarne rolfbjarne rolfbjarne approved these changes

@mandel-macaque mandel-macaque mandel-macaque approved these changes

@spouliot spouliot Awaiting requested review from spouliot

Assignees
No one assigned
Labels
note-highlight Worth calling out specifically in release notes
Projects
None yet
Milestone
xcode13.0
Development

Successfully merging this pull request may close these issues.
4 participants
@tj-devel709 @vs-mobiletools-engineering-service2 @mandel-macaque @rolfbjarne