-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CoreData] Add support for Xcode 13 beta 3. #12183
[CoreData] Add support for Xcode 13 beta 3. #12183
Conversation
src/coredata.cs
Outdated
@@ -1667,14 +1671,26 @@ interface NSPersistentHistoryTransaction : NSCopying | |||
[DisableDefaultCtor] // NSInternalInconsistencyException Reason: NSCoreDataCoreSpotlightDelegate requires the use of the initializer initForStoreWithDescription:model: | |||
interface NSCoreDataCoreSpotlightDelegate | |||
{ | |||
|
|||
[Notification] | |||
[NoWatch, NoTV, Mac (12,0), iOS (15,0), MacCatalyst (15,0)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[NoWatch]
and [NoTV]
are already present on the type declaration and does not need to be repeated on members
src/coredata.cs
Outdated
void StartSpotlightIndexing (); | ||
|
||
[NoWatch, NoTV, Mac (12,0), iOS (15,0)] | ||
[Export ("stopSpotlightIndexing"), MacCatalyst (15,0)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's legit - but it's confusing to mix availability and [Export]
inside the same [...]
[Async (ResultTypeName = "NSPersistentCloudKitContainerAcceptShareInvitationsResult")] | ||
[Watch (8,0), TV (15,0), Mac (12,0), iOS (15,0), MacCatalyst (15,0)] | ||
[Export ("acceptShareInvitationsFromMetadata:intoPersistentStore:completion:")] | ||
void AcceptShareInvitations (CKShareMetadata[] metadata, NSPersistentStore persistentStore, [NullAllowed] NSPersistentCloudKitContainerAcceptShareInvitationsHandler handler); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the NSPersistentCloudKitContainerAcceptShareInvitationsHandler
has [NoWatch]
and [NoTV]
attributes
[Async (ResultTypeName = "NSPersistentCloudKitContainerPurgeObjectsAndRecordsInZone")] | ||
[Watch (8,0), TV (15,0), Mac (12,0), iOS (15,0), MacCatalyst (15,0)] | ||
[Export ("purgeObjectsAndRecordsInZoneWithID:inPersistentStore:completion:")] | ||
void PurgeObjectsAndRecordsInZone (CKRecordZoneID zoneId, [NullAllowed] NSPersistentStore persistentStore, [NullAllowed] NSPersistentCloudKitContainerPurgeObjectsAndRecordsInZoneHandler handler); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
[Async (ResultTypeName = "NSPersistentCloudKitContainerPersistUpdatedShareResult")] | ||
[Watch (8,0), TV (15,0), Mac (12,0), iOS (15,0), MacCatalyst (15,0)] | ||
[Export ("persistUpdatedShare:inPersistentStore:completion:")] | ||
void PersistUpdatedShare (CKShare share, NSPersistentStore persistentStore, [NullAllowed] NSPersistentCloudKitContainerPersistUpdatedShareHandler handler); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
[Async (ResultTypeName = "NSPersistentCloudKitContainerFetchParticipantsMatchingLookupInfosResult")] | ||
[Watch (8,0), TV (15,0), Mac (12,0), iOS (15,0), MacCatalyst (15,0)] | ||
[Export ("fetchParticipantsMatchingLookupInfos:intoPersistentStore:completion:")] | ||
void FetchParticipantsMatchingLookupInfos (CKUserIdentityLookupInfo[] lookupInfos, NSPersistentStore persistentStore, NSPersistentCloudKitContainerFetchParticipantsMatchingLookupInfosHandler handler); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
[Async (ResultTypeName = "NSPersistentCloudKitContainerShareManagedObjectsResult")] | ||
[Watch (8,0), TV (15,0), Mac (12,0), iOS (15,0), MacCatalyst (15,0)] | ||
[Export ("shareManagedObjects:toShare:completion:")] | ||
void ShareManagedObjects (NSManagedObject[] managedObjects, [NullAllowed] CKShare share, NSPersistentCloudKitContainerShareManagedObjectsHandler handler); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All these methods, I got the first interface wrong and forgot to update the delegates, updated in a9c9067
[Export ("startSpotlightIndexing")] | ||
void StartSpotlightIndexing (); | ||
|
||
[NoWatch, NoTV, Mac (12,0), iOS (15,0),MacCatalyst (15,0)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[NoWatch, NoTV, Mac (12,0), iOS (15,0),MacCatalyst (15,0)] | |
[NoWatch, NoTV, Mac (12,0), iOS (15,0), MacCatalyst (15,0)] |
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results2 tests failed, 87 tests passed.Failed tests
Pipeline on Agent XAMBOT-1096.BigSur' |
/sudo backport release/6.0.1xx-preview7 |
Backport Job to branch release/6.0.1xx-preview7 Created! The magic is happening here |
Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=5013301 for more details. |
No description provided.