Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LocalAuthentication] Add support for Xcode 13 beta 4. #12301

Merged
merged 5 commits into from
Aug 2, 2021
Merged

[LocalAuthentication] Add support for Xcode 13 beta 4. #12301

merged 5 commits into from
Aug 2, 2021

Conversation

mandel-macaque
Copy link
Member

No description provided.

@mandel-macaque mandel-macaque added the note-highlight Worth calling out specifically in release notes label Jul 29, 2021
mandel-macaque
mandel-macaque commented Jul 29, 2021
View reviewed changes
src/LocalAuthentication/LAEnums.cs
@@ -51,6 +51,7 @@ public enum LAStatus : long {
WatchNotAvailable = -11,
BiometryNotPaired = -12,
BiometryDisconnected = -13,
InvalidDimension = -14,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is an error no atts needed.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

3 tests failed, 86 tests passed.

Failed tests

  • monotouch-test/Mac [dotnet]/Debug [dotnet]: Failed (Test run failed.
    Tests run: 2460 Passed: 2398 Inconclusive: 10 Failed: 1 Ignored: 61)
  • monotouch-test/Mac Catalyst/Debug [dotnet]: Failed (Tests run: 2629 Passed: 2490 Inconclusive: 35 Failed: 1 Ignored: 138)
  • Xtro/Mac: BuildFailure

Pipeline on Agent XAMBOT-1101.BigSur'
Merge ea7f008 into 448cc6e

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 88 tests passed.

Failed tests

  • Xtro/Mac: Failed (Test run failed.)

Pipeline on Agent XAMBOT-1094.BigSur'
Merge 2d9b3fc into 39df6c5

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build] Tests passed on Build. ✅

Tests passed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

🎉 All 89 tests passed 🎉

Pipeline on Agent XAMBOT-1096.BigSur'
Merge 66d17ae into 0f15240

@mandel-macaque mandel-macaque merged commit 0ca2038 into xamarin:main Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

@rolfbjarne rolfbjarne rolfbjarne approved these changes

@stephen-hawley stephen-hawley stephen-hawley approved these changes

@spouliot spouliot Awaiting requested review from spouliot

Assignees
No one assigned
Labels
note-highlight Worth calling out specifically in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mandel-macaque @vs-mobiletools-engineering-service2 @dalexsoto @rolfbjarne @stephen-hawley