Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AppKit] Add constructors for NSMenuToolbarItem classes #15087

Merged
merged 1 commit into from
May 23, 2022
Merged

[AppKit] Add constructors for NSMenuToolbarItem classes #15087

merged 1 commit into from
May 23, 2022

Conversation

chamons
Copy link
Contributor

@chamons chamons commented May 20, 2022

@chamons chamons added the notes-mention Deserves a mention in release notes label May 20, 2022
@chamons chamons requested a review from dalexsoto as a code owner May 20, 2022 21:09
@chamons
Copy link
Contributor Author

chamons commented May 20, 2022

I believe this is correct, specially the ctor XAMCORE_5_0 bit, but I am not certain. Please double check my work here.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1108.Monterey'
Hash: 1f0ac22a2025eb3ddaf7ead237d34368529cc502

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: 1f0ac22a2025eb3ddaf7ead237d34368529cc502

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻

✅ All tests on macOS Mac Catalina (10.15) passed.

Pipeline on Agent
Hash: 1f0ac22a2025eb3ddaf7ead237d34368529cc502

@vs-mobiletools-engineering-service2
Copy link
Collaborator

📋 [PR Build] API Diff 📋

API diff (for current PR)

ℹ️ API Diff (from PR only) (please review changes)

API diff: vsdrops gist

Xamarin
.NET
Xamarin vs .NET
iOS vs Mac Catalyst (.NET)

API diff (vs stable)

✅ API Diff from stable

API diff: vsdrops gist

Xamarin
.NET
Xamarin vs .NET
iOS vs Mac Catalyst (.NET)

Generator diff

ℹ️ Generator Diff (please review changes)

Pipeline on Agent XAMBOT-1043.Monterey'
Hash: 1f0ac22a2025eb3ddaf7ead237d34368529cc502

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [CI Build] Tests failed on VSTS: simulator tests iOS ❌

Tests failed on VSTS: simulator tests iOS.

Test results

1 tests failed, 59 tests passed.

Failed tests

  • monotouch-test/tvOS - simulator/Debug (LinkSdk) [dotnet]: Failed

Pipeline on Agent XAMBOT-1043.Monterey'
Merge 1f0ac22 into 94e40c8

@chamons chamons merged commit 560872b into xamarin:main May 23, 2022
@chamons chamons deleted the issue_15069 branch May 23, 2022 16:49
@haritha-mohan haritha-mohan mentioned this pull request Jan 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

@rolfbjarne rolfbjarne rolfbjarne approved these changes

@mandel-macaque mandel-macaque Awaiting requested review from mandel-macaque

Assignees
No one assigned
Labels
notes-mention Deserves a mention in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AppKit.NSMenuToolbarItem is missing identifier constructor in MacCatalyst
4 participants
@chamons @vs-mobiletools-engineering-service2 @dalexsoto @rolfbjarne