-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[msbuild] Use the full path to the symbols list file. Fixes #15046. #15105
Conversation
…5046. Give the full path to the symbols list file in the extension project to the main project, so that strip can find it. When building a solution remotely from Windows, we can't compute a relative path between projects, because they're laid out differently on disk. This means that we have to use full paths when passing paths between projects (such as the path to the symbol list file). Fixes xamarin#15046.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
This comment was marked as outdated.
This comment was marked as outdated.
💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻✅ All tests on macOS Mac Catalina (10.15) passed. Pipeline on Agent |
📋 [PR Build] API Diff 📋API diff (for current PR)ℹ️ API Diff (from PR only) (please review changes) .NETXamarin vs .NETAPI diff (vs stable)✅ API Diff from stable .NETXamarin vs .NETGenerator diff✅ Generator Diff (no change) Pipeline on Agent XAMBOT-1105.Monterey |
❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌Failed tests are:
Pipeline on Agent |
❌ [CI Build] Tests failed on VSTS: simulator tests iOS ❌Tests failed on VSTS: simulator tests iOS. Test results4 tests failed, 144 tests passed.Failed tests
Pipeline on Agent XAMBOT-1017.Monterey' |
Test failures are unrelated (https://github.com/xamarin/maccore/issues/2558). |
/sudo backport d17-2 |
Backport Job to branch d17-2 Created! The magic is happening here |
Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6311223 for more details. |
…15046. (#15307) Give the full path to the symbols list file in the extension project to the main project, so that strip can find it. When building a solution remotely from Windows, we can't compute a relative path between projects, because they're laid out differently on disk. This means that we have to use full paths when passing paths between projects (such as the path to the symbol list file). Fixes #15046. Backport of #15105 Co-authored-by: Rolf Bjarne Kvinge <[email protected]>
Give the full path to the symbols list file in the extension project to the
main project, so that strip can find it.
When building a solution remotely from Windows, we can't compute a relative
path between projects, because they're laid out differently on disk. This
means that we have to use full paths when passing paths between projects (such
as the path to the symbol list file).
Fixes #15046.