Nullability annotations on NSUrl #15356

Therzok · 2022-06-27T14:18:23Z

No description provided.

mandel-macaque · 2022-06-27T14:58:45Z

@Therzok can you fix all the following warnings?

* Assertion at mono-threads.c:651, condition `info' not met, function:mono_thread_info_current, 
Foundation/NSUrlSessionHandler.cs(716,24): warning CS8604: Possible null reference argument for parameter 'uriString' in 'Uri.Uri(string uriString)'.
Foundation/NSUrlSessionHandler.cs(754,56): warning CS8604: Possible null reference argument for parameter 'uriString' in 'Uri.Uri(string uriString)'.
Foundation/NSUrl.cs(58,21): warning CS8604: Possible null reference argument for parameter 'uriString' in 'Uri.Uri(string uriString, UriKind uriKind)'.
Foundation/NSUrl.cs(58,21): warning CS8604: Possible null reference argument for parameter 'uriString' in 'Uri.Uri(string uriString, UriKind uriKind)'.
Foundation/NSUrlSessionHandler.cs(716,24): warning CS8604: Possible null reference argument for parameter 'uriString' in 'Uri.Uri(string uriString)'.
Foundation/NSUrlSessionHandler.cs(754,56): warning CS8604: Possible null reference argument for parameter 'uriString' in 'Uri.Uri(string uriString)'.
Foundation/NSUrlSessionHandler.cs(716,24): warning CS8604: Possible null reference argument for parameter 'uriString' in 'Uri.Uri(string uriString)'.
Foundation/NSUrlSessionHandler.cs(754,56): warning CS8604: Possible null reference argument for parameter 'uriString' in 'Uri.Uri(string uriString)'.
Foundation/NSUrl.cs(58,21): warning CS8604: Possible null reference argument for parameter 'uriString' in 'Uri.Uri(string uriString, UriKind uriKind)'.

@tj-devel709 give a hand if it is needed since you have experience with this changes.

chamons

Approved assuming test fixes are done (my GH refresh was stale when I reviewed)

Therzok · 2022-06-28T19:04:04Z

@Therzok can you fix all the following warnings?

* Assertion at mono-threads.c:651, condition `info' not met, function:mono_thread_info_current, 
Foundation/NSUrlSessionHandler.cs(716,24): warning CS8604: Possible null reference argument for parameter 'uriString' in 'Uri.Uri(string uriString)'.
Foundation/NSUrlSessionHandler.cs(754,56): warning CS8604: Possible null reference argument for parameter 'uriString' in 'Uri.Uri(string uriString)'.
Foundation/NSUrl.cs(58,21): warning CS8604: Possible null reference argument for parameter 'uriString' in 'Uri.Uri(string uriString, UriKind uriKind)'.
Foundation/NSUrl.cs(58,21): warning CS8604: Possible null reference argument for parameter 'uriString' in 'Uri.Uri(string uriString, UriKind uriKind)'.
Foundation/NSUrlSessionHandler.cs(716,24): warning CS8604: Possible null reference argument for parameter 'uriString' in 'Uri.Uri(string uriString)'.
Foundation/NSUrlSessionHandler.cs(754,56): warning CS8604: Possible null reference argument for parameter 'uriString' in 'Uri.Uri(string uriString)'.
Foundation/NSUrlSessionHandler.cs(716,24): warning CS8604: Possible null reference argument for parameter 'uriString' in 'Uri.Uri(string uriString)'.
Foundation/NSUrlSessionHandler.cs(754,56): warning CS8604: Possible null reference argument for parameter 'uriString' in 'Uri.Uri(string uriString)'.
Foundation/NSUrl.cs(58,21): warning CS8604: Possible null reference argument for parameter 'uriString' in 'Uri.Uri(string uriString, UriKind uriKind)'.

@tj-devel709 give a hand if it is needed since you have experience with this changes.

Sure. I'm not sure about the assertion though, is it crashing on a null being passed?

rolfbjarne · 2022-06-28T19:21:39Z

The assertion is probably csc triggering a Mono/CoreCLR bug (causing mono or coreclr to crash) - in other words not a problem with this PR, so you can ignore it.

src/Foundation/NSUrl.cs

mandel-macaque · 2022-06-30T21:38:36Z

/azp run

azure-pipelines · 2022-06-30T21:39:13Z

Azure Pipelines successfully started running 1 pipeline(s).

Therzok · 2022-07-10T20:27:46Z

src/Foundation/NSUrl.cs

@@ -49,13 +49,14 @@ public bool Equals (NSUrl? url)
 		// Converts from an NSURL to a System.Uri
 		public static implicit operator Uri? (NSUrl? url)
 		{
-			if (url is null) {
+			if (url?.AbsoluteString is not string absoluteUrl) {


This confused me, as it tried to create an Uri with a null string.

Therzok · 2022-07-10T20:28:04Z

src/Foundation/NSUrlSessionHandler.cs

 			{
-				var uri = new Uri (url.AbsoluteString);


Moved marshalling to caller.

Therzok · 2022-08-05T15:33:52Z

Anything else needed on this PR?

…lability

vs-mobiletools-engineering-service2 · 2022-08-18T15:53:20Z

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

No test package could be found for tests on macOS M1 - Mac Big Sur (11.5)

Pipeline on Agent
Hash: 3be88f5bdb81e14e0af1a50bc4f92d9d51fc593c [PR build]

vs-mobiletools-engineering-service2 · 2022-08-18T15:56:34Z

❌ [PR Build] Tests on macOS Mac Catalina (10.15) failed ❌

No test package could be found for tests on macOS Mac Catalina (10.15)

Pipeline on Agent
Hash: 3be88f5bdb81e14e0af1a50bc4f92d9d51fc593c [PR build]

vs-mobiletools-engineering-service2 · 2022-08-18T16:13:06Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1043.Monterey'
Hash: 3be88f5bdb81e14e0af1a50bc4f92d9d51fc593c [PR build]

vs-mobiletools-engineering-service2 · 2022-08-18T16:23:14Z

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

~~iOS~~ (no change detected)
~~tvOS~~ (no change detected)
~~watchOS~~ (no change detected)
~~macOS~~ (no change detected)

NET (empty diffs)

~~iOS~~: (empty diff detected)
~~tvOS~~: (empty diff detected)
~~MacCatalyst~~: (empty diff detected)
~~macOS~~: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: 3be88f5bdb81e14e0af1a50bc4f92d9d51fc593c [PR build]

vs-mobiletools-engineering-service2 · 2022-08-18T19:09:02Z

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

🎉 All 172 tests passed 🎉

Failures

❌ mononative tests

🔥 Failed catastrophically on VSTS: simulator tests - mononative (no summary found).

Html Report (VSDrops) Download

❌ monotouch tests

🔥 Failed catastrophically on VSTS: simulator tests - monotouch (no summary found).

Html Report (VSDrops) Download

❌ msbuild tests

🔥 Failed catastrophically on VSTS: simulator tests - msbuild (no summary found).

Html Report (VSDrops) Download

❌ mtouch tests

🔥 Failed catastrophically on VSTS: simulator tests - mtouch (no summary found).

Html Report (VSDrops) Download

❌ xammac tests

🔥 Failed catastrophically on VSTS: simulator tests - xammac (no summary found).

Html Report (VSDrops) Download

❌ xcframework tests

🔥 Failed catastrophically on VSTS: simulator tests - xcframework (no summary found).

Html Report (VSDrops) Download

❌ xtro tests

🔥 Failed catastrophically on VSTS: simulator tests - xtro (no summary found).

Html Report (VSDrops) Download

Successes

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2022-08-19T12:52:09Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 223 tests passed 🎉