-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nullability annotations on NSUrl #15356
Conversation
This comment has been minimized.
This comment has been minimized.
@Therzok can you fix all the following warnings?
@tj-devel709 give a hand if it is needed since you have experience with this changes. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved assuming test fixes are done (my GH refresh was stale when I reviewed)
Sure. I'm not sure about the assertion though, is it crashing on a null being passed? |
The assertion is probably csc triggering a Mono/CoreCLR bug (causing mono or coreclr to crash) - in other words not a problem with this PR, so you can ignore it. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ac7312c
to
c0c4d5c
Compare
@@ -49,13 +49,14 @@ public bool Equals (NSUrl? url) | |||
// Converts from an NSURL to a System.Uri | |||
public static implicit operator Uri? (NSUrl? url) | |||
{ | |||
if (url is null) { | |||
if (url?.AbsoluteString is not string absoluteUrl) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This confused me, as it tried to create an Uri with a null string.
{ | ||
var uri = new Uri (url.AbsoluteString); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved marshalling to caller.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Anything else needed on this PR? |
❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌No test package could be found for tests on macOS M1 - Mac Big Sur (11.5) Pipeline on Agent |
❌ [PR Build] Tests on macOS Mac Catalina (10.15) failed ❌No test package could be found for tests on macOS Mac Catalina (10.15) Pipeline on Agent |
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes)
NET (empty diffs)
✅ API diff vs stableLegacy Xamarin (No breaking changes).NET (No breaking changes)✅ Generator diffGenerator diff is empty Pipeline on Agent |
🔥 [CI Build] Test results 🔥Test results❌ Tests failed on VSTS: simulator tests 🎉 All 172 tests passed 🎉 Failures❌ mononative tests🔥 Failed catastrophically on VSTS: simulator tests - mononative (no summary found). Html Report (VSDrops) Download ❌ monotouch tests🔥 Failed catastrophically on VSTS: simulator tests - monotouch (no summary found). Html Report (VSDrops) Download ❌ msbuild tests🔥 Failed catastrophically on VSTS: simulator tests - msbuild (no summary found). Html Report (VSDrops) Download ❌ mtouch tests🔥 Failed catastrophically on VSTS: simulator tests - mtouch (no summary found). Html Report (VSDrops) Download ❌ xammac tests🔥 Failed catastrophically on VSTS: simulator tests - xammac (no summary found). Html Report (VSDrops) Download ❌ xcframework tests🔥 Failed catastrophically on VSTS: simulator tests - xcframework (no summary found). Html Report (VSDrops) Download ❌ xtro tests🔥 Failed catastrophically on VSTS: simulator tests - xtro (no summary found). Html Report (VSDrops) Download Successes✅ bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: simulator tests. 🎉 All 223 tests passed 🎉 Tests counts✅ bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
No description provided.