[AuthenticationServices] Update bindings for Xcode 14 beta 1 and 2 #15427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tj-devel709
added
the
note-highlight
rolfbjarne
requested changes
Jul 8, 2022
src/authenticationservices.cs
Outdated
| @@ -252,9 +252,11 @@ interface ASPasswordCredential : NSCopying, NSSecureCoding, ASAuthorizationCrede | |||
| [BaseType (typeof (NSObject))] | |||
| [DisableDefaultCtor] | |||
| interface ASWebAuthenticationSession { | |||
| [TV (16,0)] | |||
There was a problem hiding this comment.
The type is still NoTV, so that needs to be fixed too.
src/authenticationservices.cs
Outdated
| interface ASAuthorizationProviderExtensionLoginConfiguration | ||
| { | ||
| [Export ("initWithClientID:issuer:tokenEndpointURL:jwksEndpointURL:audience:")] | ||
| NativeHandle Constructor (string clientID, string issuer, NSUrl tokenEndpointUrl, NSUrl jwksEndpointUrl, [NullAllowed] string audience); |
There was a problem hiding this comment.
Suggested change
| NativeHandle Constructor (string clientID, string issuer, NSUrl tokenEndpointUrl, NSUrl jwksEndpointUrl, [NullAllowed] string audience); | |
| NativeHandle Constructor (string clientId, string issuer, NSUrl tokenEndpointUrl, NSUrl jwksEndpointUrl, [NullAllowed] string audience); |
src/authenticationservices.cs
Outdated
|
|
||
| [Static] | ||
| [Export ("configurationWithOpenIDConfigurationURL:clientID:issuer:completion:")] | ||
| void CreateConfiguration (NSUrl openIDConfigurationUrl, string clientID, [NullAllowed] string issuer, Action<ASAuthorizationProviderExtensionLoginConfiguration, NSError> completion); |
There was a problem hiding this comment.
Suggested change
| void CreateConfiguration (NSUrl openIDConfigurationUrl, string clientID, [NullAllowed] string issuer, Action<ASAuthorizationProviderExtensionLoginConfiguration, NSError> completion); | |
| void CreateConfiguration (NSUrl openIdConfigurationUrl, string clientId, [NullAllowed] string issuer, Action<ASAuthorizationProviderExtensionLoginConfiguration, NSError> completion); |
src/authenticationservices.cs
Outdated
| string AccountDisplayName { get; set; } | ||
|
|
||
| [Export ("clientID")] | ||
| string ClientID { get; } |
There was a problem hiding this comment.
Suggested change
| string ClientID { get; } | |
| string ClientId { get; } |
| void ResetKeys (); | ||
|
|
||
| [Export ("presentRegistrationViewControllerWithCompletion:")] | ||
| void PresentRegistrationViewController (Action<NSError> completion); |
There was a problem hiding this comment.
Looks like this could be an async candidate: [Async]
| SecIdentity CopyIdentity (ASAuthorizationProviderExtensionKeyType keyType); | ||
|
|
||
| [Export ("userNeedsReauthenticationWithCompletion:")] | ||
| void ReauthenticateUser (Action<NSError> completion); |
There was a problem hiding this comment.
Looks like this could be an async candidate: [Async]
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
mandel-macaque
requested changes
Jul 8, 2022
src/authenticationservices.cs
Outdated
| @@ -252,9 +252,11 @@ interface ASPasswordCredential : NSCopying, NSSecureCoding, ASAuthorizationCrede | |||
| [BaseType (typeof (NSObject))] | |||
| [DisableDefaultCtor] | |||
| interface ASWebAuthenticationSession { | |||
| [TV (16,0)] | |||
There was a problem hiding this comment.
The type has NoTV already.
src/authenticationservices.cs
Outdated
| [Export ("initWithURL:callbackURLScheme:completionHandler:")] | ||
| NativeHandle Constructor (NSUrl url, [NullAllowed] string callbackUrlScheme, ASWebAuthenticationSessionCompletionHandler completionHandler); | ||
|
|
||
| [TV (16,0)] |
src/authenticationservices.cs
Outdated
| @@ -269,7 +271,7 @@ interface ASWebAuthenticationSession { | |||
| [Export ("prefersEphemeralWebBrowserSession")] | |||
| bool PrefersEphemeralWebBrowserSession { get; set; } | |||
|
|
|||
| [Mac (10,15,4), iOS (13,4)] | |||
| [Mac (10,15,4), iOS (13,4), TV (16,0)] | |||
|
I also am getting this build failure: |
added 3 commits
July 13, 2022 16:32
tj-devel709
added
notes-mention
|
@mandel-macaque this one should be updated to reflect requested changes now! |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
added 3 commits
July 25, 2022 09:36
…ationServices-Beta1and2
…and2' into Xcode14-AuthenticationServices-Beta1and2
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Needs updating to Beta 4 |
…ationServices-Beta1and2
|
Beta 4 changes found here: #15604 |
💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻✅ All tests on macOS Mac Catalina (10.15) passed. Pipeline on Agent |
❗ API diff for current PR / commit (Breaking changes)Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
.NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
❗ API diff vs stable (Breaking changes)Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
.NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌Failed tests are:
Pipeline on Agent |
|
I think everything is now updated and covered in Manuel's PR #15604 so probably we can close this one to avoid clashes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Binding updates for AuthenticationServices for Xcode 14