-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AuthenticationServices] Update bindings for Xcode 14 beta 1 and 2 #15427
[AuthenticationServices] Update bindings for Xcode 14 beta 1 and 2 #15427
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a few minor comments.
src/authenticationservices.cs
Outdated
@@ -252,9 +252,11 @@ interface ASPasswordCredential : NSCopying, NSSecureCoding, ASAuthorizationCrede | |||
[BaseType (typeof (NSObject))] | |||
[DisableDefaultCtor] | |||
interface ASWebAuthenticationSession { | |||
[TV (16,0)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The type is still NoTV, so that needs to be fixed too.
src/authenticationservices.cs
Outdated
interface ASAuthorizationProviderExtensionLoginConfiguration | ||
{ | ||
[Export ("initWithClientID:issuer:tokenEndpointURL:jwksEndpointURL:audience:")] | ||
NativeHandle Constructor (string clientID, string issuer, NSUrl tokenEndpointUrl, NSUrl jwksEndpointUrl, [NullAllowed] string audience); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NativeHandle Constructor (string clientID, string issuer, NSUrl tokenEndpointUrl, NSUrl jwksEndpointUrl, [NullAllowed] string audience); | |
NativeHandle Constructor (string clientId, string issuer, NSUrl tokenEndpointUrl, NSUrl jwksEndpointUrl, [NullAllowed] string audience); |
src/authenticationservices.cs
Outdated
|
||
[Static] | ||
[Export ("configurationWithOpenIDConfigurationURL:clientID:issuer:completion:")] | ||
void CreateConfiguration (NSUrl openIDConfigurationUrl, string clientID, [NullAllowed] string issuer, Action<ASAuthorizationProviderExtensionLoginConfiguration, NSError> completion); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
void CreateConfiguration (NSUrl openIDConfigurationUrl, string clientID, [NullAllowed] string issuer, Action<ASAuthorizationProviderExtensionLoginConfiguration, NSError> completion); | |
void CreateConfiguration (NSUrl openIdConfigurationUrl, string clientId, [NullAllowed] string issuer, Action<ASAuthorizationProviderExtensionLoginConfiguration, NSError> completion); |
src/authenticationservices.cs
Outdated
string AccountDisplayName { get; set; } | ||
|
||
[Export ("clientID")] | ||
string ClientID { get; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
string ClientID { get; } | |
string ClientId { get; } |
void ResetKeys (); | ||
|
||
[Export ("presentRegistrationViewControllerWithCompletion:")] | ||
void PresentRegistrationViewController (Action<NSError> completion); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this could be an async candidate: [Async]
SecIdentity CopyIdentity (ASAuthorizationProviderExtensionKeyType keyType); | ||
|
||
[Export ("userNeedsReauthenticationWithCompletion:")] | ||
void ReauthenticateUser (Action<NSError> completion); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this could be an async candidate: [Async]
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
src/authenticationservices.cs
Outdated
@@ -252,9 +252,11 @@ interface ASPasswordCredential : NSCopying, NSSecureCoding, ASAuthorizationCrede | |||
[BaseType (typeof (NSObject))] | |||
[DisableDefaultCtor] | |||
interface ASWebAuthenticationSession { | |||
[TV (16,0)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The type has NoTV already.
src/authenticationservices.cs
Outdated
[Export ("initWithURL:callbackURLScheme:completionHandler:")] | ||
NativeHandle Constructor (NSUrl url, [NullAllowed] string callbackUrlScheme, ASWebAuthenticationSessionCompletionHandler completionHandler); | ||
|
||
[TV (16,0)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same.
src/authenticationservices.cs
Outdated
@@ -269,7 +271,7 @@ interface ASWebAuthenticationSession { | |||
[Export ("prefersEphemeralWebBrowserSession")] | |||
bool PrefersEphemeralWebBrowserSession { get; set; } | |||
|
|||
[Mac (10,15,4), iOS (13,4)] | |||
[Mac (10,15,4), iOS (13,4), TV (16,0)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same.
I also am getting this build failure: |
@mandel-macaque this one should be updated to reflect requested changes now! |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…ationServices-Beta1and2
…and2' into Xcode14-AuthenticationServices-Beta1and2
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Needs updating to Beta 4 |
…ationServices-Beta1and2
Beta 4 changes found here: #15604 |
💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻✅ All tests on macOS Mac Catalina (10.15) passed. Pipeline on Agent |
❗ API diff for current PR / commit (Breaking changes)Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
.NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
❗ API diff vs stable (Breaking changes)Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
.NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌Failed tests are:
Pipeline on Agent |
I think everything is now updated and covered in Manuel's PR #15604 so probably we can close this one to avoid clashes |
Binding updates for AuthenticationServices for Xcode 14