-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UIKit] Add support for Xcode 14 up to beta 5. #15694
Conversation
tests/xtro-sharpie/tvOS-UIKit.ignore
Outdated
@@ -330,11 +330,11 @@ | |||
!missing-null-allowed! 'UIKit.UIWindow UIKit.UIView::get_Window()' is missing an [NullAllowed] on return type | |||
|
|||
## not available on tvOS (iOS 14+ only) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment is commenting about nothing now
src/UIKit/UIEnums.cs
Outdated
@@ -779,6 +779,10 @@ public enum UIDataDetectorType : ulong { | |||
FlightNumber = 1 << 5, | |||
[iOS (10,0)] | |||
LookupSuggestion = 1 << 6, | |||
[NoWatch, NoTV, iOS (16,0), MacCatalyst (16,0)] | |||
Money = 1uL << 7, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor - either use 1 << 7
here to be consistent with all the others or change the others to be 1uL << n
. I would personally do the former since the backing type is ulong
so the uL
is redundant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Left some suggestions :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was a Herculean task. Nice.
@@ -2900,10 +3091,12 @@ interface UIContextMenuInteractionDelegate { | |||
[return: NullAllowed] | |||
UIContextMenuConfiguration GetConfigurationForMenu (UIContextMenuInteraction interaction, CGPoint location); | |||
|
|||
[Deprecated (PlatformName.iOS, 16, 0)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should there be a message for this? I don't know our typical policy for this. Personally, I view deprecation as either a detour sign (what's my alternative?) or an apology.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should, but we do not know the reason, so I can only say it was deprecated by apple.
[Watch (9,0), TV (16,0), MacCatalyst (16,0), iOS (16,0)] | ||
[Static] | ||
[Export ("configurationPreferringMonochrome")] | ||
UIImageSymbolConfiguration GetConfigurationPreferringMonochrome (); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be a property instead of a method? It takes no parameters and returns a single value...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know, let me check with the rest of the API what is what we usually done. Is better to be consistent.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Rolf Bjarne Kvinge <[email protected]> Co-authored-by: TJ Lambert <[email protected]>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
// TODO: Enable when Foundation return type is bound | ||
// [Export ("difference")] | ||
// NSOrderedCollectionDifference<ItemIdentifierType> Difference { get; } | ||
#if false // https://github.com/xamarin/xamarin-macios/issues/15577 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
src/uikit.cs
Outdated
string ReplacementText { get; set; } | ||
|
||
[NullAllowed, Export ("optionsMenuProvider", ArgumentSemantic.Copy)] | ||
Func<NSArray<UIMenuElement>, UIMenu> OptionsMenuProvider { get; set; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe use this instead of the func? to avoid the NSArray
delegate UIMenu OptionsMenuProviderHandler (UIMenuElement [] elements);
Co-authored-by: Alex Soto <[email protected]>
…ios into uikit-xcode14
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes).NET (No breaking changes)✅ API diff vs stableLegacy Xamarin (No breaking changes).NET (No breaking changes)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻✅ All tests on macOS Mac Catalina (10.15) passed. Pipeline on Agent |
❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌Failed tests are:
Pipeline on Agent |
🔥 [CI Build] Test results 🔥Test results❌ Tests failed on VSTS: simulator tests 0 tests crashed, 1 tests failed, 227 tests passed. Failures❌ introspection tests
Html Report (VSDrops) Download Successes✅ bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
Crashed Known issue: https://github.com/xamarin/maccore/issues/581 |
No description provided.