[generator] Use new ObsoletedOSPlatformAttribute for generated code #15941

chamons · 2022-09-12T18:39:42Z

Part of Make use of the new ObsoletedOSPlatformAttribute in .NET 7 #15849
A bit of dead code was removed while I was reviewing things.

- Part of xamarin#15849

chamons · 2022-09-12T18:40:39Z

I reviewed examples of the generated code and found no changes in legacy and what looked reasonable in NET builds.

src/generator-attributes.cs

rolfbjarne

The changes look correct, but it seems a number of tests have to be updated as well.

~~Some of the monotouch-test tests are unrelated - you can fix those by merging net7.0 into your branch.~~ (the fix isn't in net7.0 yet). There's at least one that is related though ("DelegateAndDataSourceAllowsNull: 2 failing types").

chamons · 2022-09-20T17:48:31Z

I'll fix DelegateAndDataSourceAllowsNull up and wait for you to tell me net7.0 is fixed.

chamons · 2022-09-20T19:20:48Z

[13:55:30.4847390] 	[FAIL] DelegateAndDataSourceAllowsNull : 2 failing types
[13:55:30.4848160] 2 failing types:
[13:55:30.4848270] GameKit.GKAchievementViewController: Could not initialize an instance of the type 'GameKit.GKAchievementViewController': the native 'init' method returned nil.
[13:55:30.4848380] It is possible to ignore this condition by setting ObjCRuntime.Class.ThrowOnInitFailure to false.
[13:55:30.4848470] GameKit.GKLeaderboardViewController: Could not initialize an instance of the type 'GameKit.GKLeaderboardViewController': the native 'init' method returned nil.
[13:55:30.4848550] It is possible to ignore this condition by setting ObjCRuntime.Class.ThrowOnInitFailure to false.
[13:55:30.4848630]

…ribute

rolfbjarne · 2022-09-21T10:56:52Z

@chamons the unrelated failing monotouch-test tests should be fixed now.

The other test failures (cecil, introspection, xtro) all look related to the changes in this PR.

… entire framework is missing (like carplay)

stephen-hawley · 2022-10-04T20:36:33Z

👀

vs-mobiletools-engineering-service2 · 2022-10-05T07:46:51Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1042.Monterey'
Hash: b8c9a98b656b88a80a8e7512d5170966b16de34e [PR build]

vs-mobiletools-engineering-service2 · 2022-10-05T07:55:21Z

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: b8c9a98b656b88a80a8e7512d5170966b16de34e [PR build]

vs-mobiletools-engineering-service2 · 2022-10-05T08:08:20Z

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

~~iOS~~ (no change detected)
~~tvOS~~ (no change detected)
~~watchOS~~ (no change detected)
~~macOS~~ (no change detected)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: b8c9a98b656b88a80a8e7512d5170966b16de34e [PR build]

vs-mobiletools-engineering-service2 · 2022-10-05T10:05:09Z

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 13 tests failed, 210 tests passed.

Failures

❌ bcl tests

11 tests failed, 58 tests passed.

[NUnit] Mono BCL tests group 1/tvOS - simulator/Debug: LaunchTimedOut
[NUnit] Mono BCL tests group 2/tvOS - simulator/Debug: LaunchTimedOut
[xUnit] Mono BCL tests group 3/tvOS - simulator/Debug: LaunchTimedOut
[xUnit] Mono BCL tests group 4/tvOS - simulator/Debug: LaunchTimedOut
[xUnit] Mono BCL tests group 5/tvOS - simulator/Debug: LaunchTimedOut
mscorlib Part 1/tvOS - simulator/Debug: LaunchTimedOut
mscorlib Part 2/tvOS - simulator/Debug: LaunchTimedOut
mscorlib Part 3/tvOS - simulator/Debug: LaunchTimedOut
[xUnit] Mono SystemCoreXunit Part 1/tvOS - simulator/Debug: LaunchTimedOut
[xUnit] Mono SystemCoreXunit Part 2/tvOS - simulator/Debug: LaunchTimedOut
[xUnit] Mono SystemXunit/tvOS - simulator/Debug: LaunchTimedOut

Html Report (VSDrops) Download

❌ framework tests

2 tests failed, 6 tests passed.

framework-test/tvOS - simulator/Debug [dotnet]: LaunchTimedOut
framework-test/tvOS - simulator/Debug: LaunchTimedOut

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 23 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2022-10-05T14:45:00Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 223 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 23 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: [PR build]

[generator] Use new ObsoletedOSPlatformAttribute for generated code

8fe969f

- Part of xamarin#15849

chamons requested review from dalexsoto and rolfbjarne as code owners September 12, 2022 18:39

chamons added the notes-mention Deserves a mention in release notes label Sep 12, 2022

This comment has been minimized.

Sign in to view

rolfbjarne requested changes Sep 13, 2022

View reviewed changes

src/generator-attributes.cs Show resolved Hide resolved

src/generator-attributes.cs Show resolved Hide resolved

src/generator-attributes.cs Outdated Show resolved Hide resolved

chamons added 3 commits September 13, 2022 15:00

Merge branch 'net7.0' into net7.0_obsolete_attribute

2d5aedb

Merge branch 'net7.0' into net7.0_obsolete_attribute

1bc338f

Code review changes

6f16d17

This comment has been minimized.

Sign in to view

dalexsoto approved these changes Sep 19, 2022

View reviewed changes

rolfbjarne self-requested a review September 19, 2022 16:12

This comment has been minimized.

Sign in to view

rolfbjarne requested changes Sep 20, 2022

View reviewed changes

Merge remote-tracking branch 'origin/net7.0' into net7.0_obsolete_att…

2aef5d4

…ribute

This comment has been minimized.

Sign in to view

chamons added 4 commits October 4, 2022 12:35

[generator] Also strip deprecated attributes that are nonsense becaue…

ce6c6be

… entire framework is missing (like carplay)

[generator] Imply tvOS from iOS in NET6 just like Catalyst

7af5972

Manual binding corrections for improved xtro testing

eeffe83

[tests] Update intro/xtro for new Obsolete and remove todos

9b48210

chamons requested review from rolfbjarne and dalexsoto October 4, 2022 17:53

Merge branch 'net7.0' into net7.0_obsolete_attribute

f544689

This comment has been minimized.

Sign in to view

dalexsoto approved these changes Oct 4, 2022

View reviewed changes

[tests] We're generating even more attributes now.

ab08af9

rolfbjarne approved these changes Oct 5, 2022

View reviewed changes

[xtro] Add missing eof.

b8c9a98

mandel-macaque approved these changes Oct 6, 2022

View reviewed changes

chamons merged commit 83ed66e into xamarin:net7.0 Oct 6, 2022

chamons deleted the net7.0_obsolete_attribute branch October 6, 2022 16:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[generator] Use new ObsoletedOSPlatformAttribute for generated code #15941

[generator] Use new ObsoletedOSPlatformAttribute for generated code #15941

chamons commented Sep 12, 2022

chamons commented Sep 12, 2022

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rolfbjarne left a comment •

edited

Loading

chamons commented Sep 20, 2022

chamons commented Sep 20, 2022

rolfbjarne commented Sep 21, 2022

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

stephen-hawley commented Oct 4, 2022

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Oct 5, 2022

vs-mobiletools-engineering-service2 commented Oct 5, 2022

vs-mobiletools-engineering-service2 commented Oct 5, 2022

vs-mobiletools-engineering-service2 commented Oct 5, 2022

vs-mobiletools-engineering-service2 commented Oct 5, 2022

[generator] Use new ObsoletedOSPlatformAttribute for generated code #15941

[generator] Use new ObsoletedOSPlatformAttribute for generated code #15941

Conversation

chamons commented Sep 12, 2022

chamons commented Sep 12, 2022

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rolfbjarne left a comment • edited Loading

Choose a reason for hiding this comment

chamons commented Sep 20, 2022

chamons commented Sep 20, 2022

rolfbjarne commented Sep 21, 2022

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

stephen-hawley commented Oct 4, 2022

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Oct 5, 2022

📚 [PR Build] Artifacts 📚

Packages generated

vs-mobiletools-engineering-service2 commented Oct 5, 2022

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

vs-mobiletools-engineering-service2 commented Oct 5, 2022

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

vs-mobiletools-engineering-service2 commented Oct 5, 2022

🔥 [CI Build] Test results 🔥

Test results

Failures

❌ bcl tests

❌ framework tests

Successes

vs-mobiletools-engineering-service2 commented Oct 5, 2022

🚀 [CI Build] Test results 🚀

Test results

Tests counts

rolfbjarne left a comment •

edited

Loading