-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CoreMedia] Don't use 'bool' in an [UnmanagedCallersOnly] method. #15986
Conversation
'bool' isn't a blittable type, so it can't be used in an [UnmanagedCallersOnly] method. FWIW it's a bug in the C# compiler to not complain about this: dotnet/roslyn#64086. Fixes this crash in the AOT compiler: > * Assertion at /Users/runner/work/1/s/src/mono/mono/mini/aot-compiler.c:5142, condition `is_ok (error)' not met, function:add_wrappers, method CoreMedia.CMBufferQueue:GetDataReady (intptr,intptr) with UnmanagedCallersOnlyAttribute has non-blittable parameters or return type assembly:<unknown assembly> type:<unknown type> member:(null) Also exclude some unused delegates from .NET code.
💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻✅ All tests on macOS Mac Catalina (10.15) passed. Pipeline on Agent |
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes)
NET (empty diffs)
✅ API diff vs stableLegacy Xamarin (No breaking changes).NET (No breaking changes)✅ Generator diffGenerator diff is empty Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11.5) passed. Pipeline on Agent |
🔥 [CI Build] Test results 🔥Test results❌ Tests failed on VSTS: simulator tests 1 tests crashed, 1 tests failed, 157 tests passed. Failures❌ linker tests🔥 Failed catastrophically on VSTS: simulator tests - linker (no summary found). Html Report (VSDrops) Download ❌ monotouch tests
Html Report (VSDrops) Download Successes✅ bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: simulator tests. 🎉 All 223 tests passed 🎉 Tests counts✅ bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
'bool' isn't a blittable type, so it can't be used in an
[UnmanagedCallersOnly] method.
FWIW it's a bug in the C# compiler to not complain about this:
dotnet/roslyn#64086.
Fixes this crash in the AOT compiler:
Also exclude some unused delegates from .NET code.