Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[StoreKit] Added support for Xcode 14.1 b1-b3 #16026

Merged
merged 7 commits into from
Oct 5, 2022
Merged

[StoreKit] Added support for Xcode 14.1 b1-b3 #16026

merged 7 commits into from
Oct 5, 2022

Conversation

SotoiGhost
Copy link
Contributor

No description provided.

@SotoiGhost SotoiGhost added the notes-mention Deserves a mention in release notes label Sep 20, 2022
@SotoiGhost SotoiGhost added this to the xcode14.1 milestone Sep 20, 2022
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@SotoiGhost SotoiGhost changed the title [StoreKit] Added support for Xcode 14.1 b1 [StoreKit] Added support for Xcode 14.1 b1-b3 Sep 28, 2022
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@mandel-macaque mandel-macaque marked this pull request as ready for review October 3, 2022 16:09
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
rolfbjarne
rolfbjarne requested changes Oct 4, 2022
View reviewed changes
src/storekit.cs Outdated
@@ -995,21 +1001,33 @@ interface SKAdNetwork {
[Static]
[Async]
[Export ("startImpression:completionHandler:")]
void StartImpression (SKAdImpression impression, [NullAllowed] Action<NSError> completion);
void StartImpression (SKAdImpression impression, [NullAllowed] SKAdNetworkCompletionHandler completion);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change, you can only add a new overload, not change existing parameter types.

src/storekit.cs Outdated

[NoWatch, NoTV, NoMac]
[iOS (14,5)]
[MacCatalyst (14,5)]
[Static]
[Async]
[Export ("endImpression:completionHandler:")]
void EndImpression (SKAdImpression impression, [NullAllowed] Action<NSError> completion);
void EndImpression (SKAdImpression impression, [NullAllowed] SKAdNetworkCompletionHandler completion);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

src/storekit.cs Outdated

[NoWatch, NoTV, NoMac, iOS (15,4), MacCatalyst (15,4)]
[Static]
[Async]
[Export ("updatePostbackConversionValue:completionHandler:")]
void UpdatePostback (nint conversionValue, [NullAllowed] Action<NSError> completion);
void UpdatePostback (nint conversionValue, [NullAllowed] SKAdNetworkCompletionHandler completion);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

src/storekit.cs Outdated Show resolved Hide resolved
src/storekit.cs Outdated Show resolved Hide resolved
@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS: vsdrops gist (No breaking changes)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
.NET (No breaking changes)
  • iOS: vsdrops gist (No breaking changes)
  • tvOS: (empty diff detected)
  • MacCatalyst: vsdrops gist (No breaking changes)
  • macOS: (empty diff detected)

❗ API diff vs stable (Breaking changes)

Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
.NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
Legacy Xamarin (stable) vs .NET

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: ebf27ef80748b676134a4157e16e129f1d2e84f3 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1178.Monterey'
Hash: ebf27ef80748b676134a4157e16e129f1d2e84f3 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

  • linksdk
  • xammac_tests
  • monotouch-test

Pipeline on Agent
Hash: ebf27ef80748b676134a4157e16e129f1d2e84f3 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 19 tests failed, 209 tests passed.

Failures

❌ bcl tests

10 tests failed, 59 tests passed.
  • [NUnit] Mono Mac OS X BCL tests group 3/Mac Modern/Debug: Failed (Test run failed.
    Tests run: 8755 Passed: 8174 Inconclusive: 0 Failed: 1 Ignored: 46)
  • [NUnit] Mono BCL tests group 1/iOS Unified 64-bits - simulator/Debug: BuildFailure
  • [NUnit] Mono BCL tests group 2/iOS Unified 64-bits - simulator/Debug: BuildFailure
  • [xUnit] Mono BCL tests group 3/iOS Unified 64-bits - simulator/Debug: BuildFailure
  • [xUnit] Mono BCL tests group 4/iOS Unified 64-bits - simulator/Debug: BuildFailure
  • [xUnit] Mono BCL tests group 5/iOS Unified 64-bits - simulator/Debug: BuildFailure
  • mscorlib Part 1/iOS Unified 64-bits - simulator/Debug: BuildFailure
  • mscorlib Part 2/iOS Unified 64-bits - simulator/Debug: BuildFailure
  • mscorlib Part 3/iOS Unified 64-bits - simulator/Debug: BuildFailure
  • [xUnit] Mono SystemCoreXunit Part 1/iOS Unified 64-bits - simulator/Debug: BuildFailure

Html Report (VSDrops) Download

❌ introspection tests

1 tests failed, 12 tests passed.
  • introspection/watchOS 32-bits - simulator/Debug (watchOS 6.0): Crashed Known issue: HE0038)

Html Report (VSDrops) Download

❌ linker tests

5 tests failed, 60 tests passed.
  • dont link/iOS Unified 64-bits - simulator/Release [dotnet]: LaunchTimedOut
  • dont link/iOS Unified 64-bits - simulator/Release: LaunchTimedOut
  • trimmode copy/iOS Unified 64-bits - simulator/Release [dotnet]: LaunchTimedOut
  • trimmode link/iOS Unified 64-bits - simulator/Debug [dotnet]: LaunchTimedOut
  • link all/iOS Unified 64-bits - simulator/Release: LaunchTimedOut

Html Report (VSDrops) Download

❌ monotouch tests

3 tests failed, 20 tests passed.
  • monotouch-test/iOS Unified 64-bits - simulator/Debug (static registrar) [dotnet]: LaunchTimedOut
  • monotouch-test/iOS Unified 64-bits - simulator/Release (all optimizations): LaunchTimedOut
  • monotouch-test/watchOS 32-bits - simulator/Debug: TimedOut

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: [PR build]

@mandel-macaque
Copy link
Member

Failures are unrelated.

@mandel-macaque mandel-macaque merged commit 66ae01a into xamarin:xcode14.1 Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

@rolfbjarne rolfbjarne rolfbjarne approved these changes

@mandel-macaque mandel-macaque mandel-macaque approved these changes

@chamons chamons chamons approved these changes

@stephen-hawley stephen-hawley stephen-hawley approved these changes

@tj-devel709 tj-devel709 tj-devel709 approved these changes

Assignees
No one assigned
Labels
notes-mention Deserves a mention in release notes
Projects
None yet
Milestone
xcode14.1
Development

Successfully merging this pull request may close these issues.
8 participants
@SotoiGhost @vs-mobiletools-engineering-service2 @mandel-macaque @dalexsoto @rolfbjarne @chamons @stephen-hawley @tj-devel709