-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/7.0.1xx-xcode14-rc2] Disable objc_msgSend stubs in clang. Fixes #16223. #16232
Conversation
Clang will by default emit objc_msgSend stubs in Xcode 14, which ld from earlier Xcodes doesn't understand. We disable this by passing -fno-objc-msgsend-selector-stubs to clang. Ref: https://developer.apple.com/videos/play/wwdc2022/110363/ Ref: https://www.wwdcnotes.com/notes/wwdc22/110363/ Ref: llvm/llvm-project#56034 Fixes xamarin#16223.
❌ [PR Build] Tests on macOS Mac Catalina (10.15) failed ❌No test package could be found for tests on macOS Mac Catalina (10.15) Pipeline on Agent |
❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌No test package could be found for tests on macOS M1 - Mac Big Sur (11.5) Pipeline on Agent |
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes)
.NET (No breaking changes)✅ API diff vs stableLegacy Xamarin (No breaking changes).NET (No breaking changes)✅ Generator diffGenerator diff is empty Pipeline on Agent |
🔥 [CI Build] Test results 🔥Test results❌ Tests failed on VSTS: simulator tests 0 tests crashed, 2 tests failed, 158 tests passed. Failures❌ introspection tests
Html Report (VSDrops) Download Successes✅ bcl: All 59 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
Test failures are unrelated (https://github.com/xamarin/maccore/issues/2450). |
Clang will by default emit objc_msgSend stubs in Xcode 14, which ld from
earlier Xcodes doesn't understand. We disable this by passing
-fno-objc-msgsend-selector-stubs to clang.
Ref: https://developer.apple.com/videos/play/wwdc2022/110363/
Ref: https://www.wwdcnotes.com/notes/wwdc22/110363/
Ref: llvm/llvm-project#56034
Fixes #16223.
Backport of #16231