[illink] Ensure we replace the dotnet SDK path in the _ExtraTrimmerArgs for remote builds #16294
Conversation
…gs for remote builds From net7, the original ILLInk targets are adding a new link attribute pointing to a supressions file inside the ILLink tasks folder, e.g: '--link-attributes "C:\Program Files\dotnet\sdk\7.0.100-rc.2.22477.23\Sdks\Microsoft.NET.ILLink.Tasks\build\6.0_suppressions.xml"'. For remote builds, we need to replace the original dotnet folder with the XMA dotnet folder in the Mac, so in our override targets we replace this value before passing it to the ILLink task
|
/sudo backport release/7.0.1xx-xcode14-rc2 |
|
/sudo backport release/7.0.1xx-rc2 |
|
Backport Job to branch release/7.0.1xx-xcode14-rc2 Created! The magic is happening here |
|
/sudo backport release/6.0.4xx-xcode14 |
|
Backport Job to branch release/7.0.1xx-rc2 Created! The magic is happening here |
|
Backport Job to branch release/6.0.4xx-xcode14 Created! The magic is happening here |
|
Oh no! Backport failed! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6795203 for more details. |
|
Oh no! Backport failed! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6795205 for more details. |
|
Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6795211 for more details. |
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes)
NET (empty diffs)
✅ API diff vs stableLegacy Xamarin (No breaking changes).NET (No breaking changes)✅ Generator diffGenerator diff is empty Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11.5) passed. Pipeline on Agent |
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: simulator tests. 🎉 All 223 tests passed 🎉 Tests counts✅ bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
rolfbjarne
changed the title
|
/sudo backport release/7.0.1xx-rc2 |
|
Backport Job to branch release/7.0.1xx-rc2 Created! The magic is happening here |
|
Oh no! Backport failed! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6801407 for more details. |
|
@dalexsoto @rolfbjarne the backport to release/7.0.1xx-rc2 keep failing :/ |
|
@mauroa that branch only builds packages for macOS and Mac Catalyst (not iOS) - do we still need this patch in that case? |
…ath in the _ExtraTrimmerArgs for remote builds (#16295) From net7, the original ILLInk targets are adding a new link attribute pointing to a supressions file inside the ILLink tasks folder, e.g: '--link-attributes "C:\Program Files\dotnet\sdk\7.0.100-rc.2.22477.23\Sdks\Microsoft.NET.ILLink.Tasks\build\6.0_suppressions.xml"'. For remote builds, we need to replace the original dotnet folder with the XMA dotnet folder in the Mac, so in our override targets we replace this value before passing it to the ILLink task Backport of #16294 Co-authored-by: Mauro Agnoletti <[email protected]>
|
/sudo backport release/7.0.1xx-xcode14-rc2 |
|
Backport Job to branch release/7.0.1xx-xcode14-rc2 Created! The magic is happening here |
|
Oh no! Backport failed! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6806668 for more details. |
…DK path in the _ExtraTrimmerArgs for remote builds. From net7, the original ILLInk targets are adding a new link attribute pointing to a supressions file inside the ILLink tasks folder, e.g: '--link-attributes "C:\Program Files\dotnet\sdk\7.0.100-rc.2.22477.23\Sdks\Microsoft.NET.ILLink.Tasks\build\6.0_suppressions.xml"'. For remote builds, we need to replace the original dotnet folder with the XMA dotnet folder in the Mac, so in our override targets we replace this value before passing it to the ILLink task Backport of xamarin#16294.
…DK path in the _ExtraTrimmerArgs for remote builds. (#16311) From net7, the original ILLInk targets are adding a new link attribute pointing to a supressions file inside the ILLink tasks folder, e.g: '--link-attributes "C:\Program Files\dotnet\sdk\7.0.100-rc.2.22477.23\Sdks\Microsoft.NET.ILLink.Tasks\build\6.0_suppressions.xml"'. For remote builds, we need to replace the original dotnet folder with the XMA dotnet folder in the Mac, so in our override targets we replace this value before passing it to the ILLink task Backport of #16294. Co-authored-by: Mauro Agnoletti <[email protected]>
…gs for remote builds
From net7, the original ILLInk targets are adding a new link attribute pointing to a supressions file inside the ILLink tasks folder, e.g: '--link-attributes "C:\Program Files\dotnet\sdk\7.0.100-rc.2.22477.23\Sdks\Microsoft.NET.ILLink.Tasks\build\6.0_suppressions.xml"'.
For remote builds, we need to replace the original dotnet folder with the XMA dotnet folder in the Mac, so in our override targets we replace this value before passing it to the ILLink task