-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AVFoundation] Improve the callback in AVAssetImageGenerator.GenerateCGImagesAsynchronously. #16325
[AVFoundation] Improve the callback in AVAssetImageGenerator.GenerateCGImagesAsynchronously. #16325
Conversation
…CGImagesAsynchronously. Add an overload to AVAssetImageGenerator.GenerateCGImagesAsynchronously that takes a callback we call with a managed CGImage instance instead of a CGImage handle. This makes the API a bit easier to use. Ref: xamarin#16314
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes).NET (No breaking changes)✅ API diff vs stableLegacy Xamarin (No breaking changes).NET (No breaking changes)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌Failed tests are:
Pipeline on Agent |
🔥 [CI Build] Test results 🔥Test results❌ Tests failed on VSTS: simulator tests 0 tests crashed, 1 tests failed, 222 tests passed. Failures❌ bcl tests
Html Report (VSDrops) Download Successes✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: simulator tests. 🎉 All 223 tests passed 🎉 Tests counts✅ bcl: All 69 tests passed. [attempt 2] Html Report (VSDrops) Download Pipeline on Agent |
Add an overload to AVAssetImageGenerator.GenerateCGImagesAsynchronously that
takes a callback we call with a managed CGImage instance instead of a CGImage handle.
This makes the API a bit easier to use.
Ref: #16314