[net8.0] Bump min OS versions to what Xcode 14 supports. Fixes #15216. #16864

rolfbjarne · 2022-11-22T09:55:29Z

Bump min OS versions to:

iOS 11.0
tvOS 11.0
watchOS 4.0 (not really relevant for .NET, but matches iOS 11.0)
macOS 10.15

Also bump the min version to execute our tooling to the macOS min version (it
doesn't make sense to be able to run our tooling on an OS you can't run the
compiled results on).

Fixes #15216.

This PR is best reviewed commit-by-commit.

github-actions · 2022-11-23T16:21:49Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

vs-mobiletools-engineering-service2 · 2022-11-24T09:01:45Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

…a version we actually support.

Additionally remove a lot of 64-bit-specific configurations (Debug64/Release64) as well, and just make the default configurations (Debug/Release) be 64-bit.

No OS version we currently support require the Compat option, so just remove it.

…iOS.

…uilding for a higher min OS version.

This was done using this script: https://gist.github.com/rolfbjarne/420aad0666d0b651804b64a6147412d6.

vs-mobiletools-engineering-service2 · 2023-02-03T09:52:59Z

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: 11a915e102bc6b0c74ab38d83b1c41659ff064b1 [PR build]

vs-mobiletools-engineering-service2 · 2023-02-03T10:08:15Z

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

~~iOS~~ (no change detected)
~~tvOS~~ (no change detected)
~~watchOS~~ (no change detected)
~~macOS~~ (no change detected)

NET (empty diffs)

~~iOS~~: (empty diff detected)
~~tvOS~~: (empty diff detected)
~~MacCatalyst~~: (empty diff detected)
~~macOS~~: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 11a915e102bc6b0c74ab38d83b1c41659ff064b1 [PR build]

vs-mobiletools-engineering-service2 · 2023-02-03T18:01:19Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 219 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 6 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 25 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 11a915e102bc6b0c74ab38d83b1c41659ff064b1 [PR build]

rolfbjarne requested review from emaf and mauroa as code owners November 22, 2022 09:55

This comment has been minimized.

Sign in to view

rolfbjarne marked this pull request as draft November 22, 2022 19:26

This comment has been minimized.

Sign in to view

rolfbjarne added 9 commits February 2, 2023 16:30

[tests] Bump min OS versions in all tests.

94a3903

[dotnet] Bump the default SupportedOSPlatformVersion in templates to …

d43c763

…a version we actually support.

[tests] Remove 32-bit architectures and logic from project files.

c54f623

Additionally remove a lot of 64-bit-specific configurations (Debug64/Release64) as well, and just make the default configurations (Debug/Release) be 64-bit.

[tools/tests] Remove the Compat option for the MonoNative library.

ca930e3

No OS version we currently support require the Compat option, so just remove it.

[msbuild] Bump the default architecture to a 64-bit architecture for …

8290697

…iOS.

[tests] Update test verifying min OS versions of our native code.

9c8db7e

[tests] Adjust an MMP test to handle a fixed warning now that we're b…

b34f5ac

…uilding for a higher min OS version.

[tests] Update MSBuild tests after bumping min OS version.

cf5d046

[dotnet] Bump min macOS version in XIB to 10.15.

e6ef460

rolfbjarne force-pushed the bump-min-os-versions branch from aa8fec3 to 4858d66 Compare February 2, 2023 15:36

This comment has been minimized.

Sign in to view

rolfbjarne and others added 4 commits February 3, 2023 09:10

[src] Remove redundant availability attributes.

6bb4d7e

This was done using this script: https://gist.github.com/rolfbjarne/420aad0666d0b651804b64a6147412d6.

[cecil-tests] Remove a known failure that's been fixed now.

7f52b11

Auto-format source code

ccea692

[tests] Update generator tests.

11a915e

rolfbjarne force-pushed the bump-min-os-versions branch from 4858d66 to 11a915e Compare February 3, 2023 08:12

This comment has been minimized.

Sign in to view

rolfbjarne marked this pull request as ready for review February 3, 2023 17:28

rolfbjarne requested review from mandel-macaque and dalexsoto as code owners February 3, 2023 17:28

mandel-macaque approved these changes Feb 6, 2023

View reviewed changes

dalexsoto approved these changes Feb 6, 2023

View reviewed changes

rolfbjarne merged commit b2165df into xamarin:net8.0 Feb 7, 2023

rolfbjarne deleted the bump-min-os-versions branch February 7, 2023 06:16

[net8.0] Bump min OS versions to what Xcode 14 supports. Fixes #15216. #16864

[net8.0] Bump min OS versions to what Xcode 14 supports. Fixes #15216. #16864

Conversation

rolfbjarne commented Nov 22, 2022 • edited Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Nov 23, 2022

⚠️ Your code has been reformatted. ⚠️

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Nov 24, 2022

📚 [PR Build] Artifacts 📚

Packages generated

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Feb 3, 2023

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

vs-mobiletools-engineering-service2 commented Feb 3, 2023

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Feb 3, 2023

🚀 [CI Build] Test results 🚀

Test results

Tests counts

rolfbjarne commented Nov 22, 2022 •

edited

Loading