Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[msbuild] Add DT* entries to the Info.plist for all platforms. Fixes #13300. #17499

Merged
merged 1 commit into from
Feb 10, 2023
Merged

[msbuild] Add DT* entries to the Info.plist for all platforms. Fixes #13300. #17499

merged 1 commit into from
Feb 10, 2023

Conversation

rolfbjarne
Copy link
Member

Modify the code to add Xcode (DT*) variables to the Info.plist:

  • Do it for all platforms, not only mobile platforms. Apple uses these fields to
    determine if an app was built with a prerelease or old version of Xcode, and will
    reject any app submissions if this validation fails.

  • Change the behavior to do not distinguish simulator builds, a bit of testing
    in Xcode shows that Xcode always adds these values to the Info.plist, even for
    simulator builds. This is probably something that changed in Xcode a long time
    ago, since this code is old (from the initial import of the build logic from MonoDevelop
    around 10 years ago).

  • Also bump Xamarin.MacDev to get a related fix:

    New commits in xamarin/Xamarin.MacDev:

    Diff: https://github.com/xamarin/Xamarin.MacDev/compare/14d53612d4624459a7ae617141c45e940ada6df5..74c95ee1c345cc194a35e6f0c9400f6a55a9b617

Fixes #13300.

@rolfbjarne
[msbuild] Add DT* entries to the Info.plist for all platforms. Fixes …
4bab69d 
…xamarin/Xamarin.MacDev#13300.

Modify the code to add Xcode (DT*) variables to the Info.plist:

* Do it for all platforms, not only mobile platforms. Apple uses these fields to
  determine if an app was built with a prerelease or old version of Xcode, and will
  reject any app submissions if this validation fails.

* Change the behavior to do not distinguish simulator builds, a bit of testing
  in Xcode shows that Xcode always adds these values to the Info.plist, even for
  simulator builds. This is probably something that changed in Xcode a *long* time
  ago, since this code is old (from the initial import of the build logic from MonoDevelop
  around 10 years ago).

* Also bump Xamarin.MacDev to get a related fix:

  New commits in xamarin/Xamarin.MacDev:

  * xamarin/Xamarin.MacDev@74c95ee [Xamarin.MacDev] Always fetch the DTSDKBuild variable.

  Diff: https://github.com/xamarin/Xamarin.MacDev/compare/14d53612d4624459a7ae617141c45e940ada6df5..74c95ee1c345cc194a35e6f0c9400f6a55a9b617

Fixes xamarin#13300.
@rolfbjarne rolfbjarne added the bug If an issue is a bug or a pull request a bug fix label Feb 10, 2023
@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: 4bab69d61d3df44a446a6abc5aeb1a2bd964a13e [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: 4bab69d61d3df44a446a6abc5aeb1a2bd964a13e [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1042.Monterey'
Hash: 4bab69d61d3df44a446a6abc5aeb1a2bd964a13e [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 1 tests failed, 224 tests passed.

Failures

❌ bcl tests

1 tests failed, 68 tests passed.
  • mscorlib Part 3/tvOS - simulator/Debug: Crashed

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 25 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 4bab69d61d3df44a446a6abc5aeb1a2bd964a13e [PR build]

@rolfbjarne
Copy link
Member Author

Test failure is unrelated (https://github.com/xamarin/maccore/issues/2450).

@rolfbjarne rolfbjarne merged commit 8e4f22d into xamarin:main Feb 10, 2023
@rolfbjarne rolfbjarne deleted the issue-13300 branch February 10, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Therzok Therzok Therzok approved these changes

@dalexsoto dalexsoto dalexsoto approved these changes

@mandel-macaque mandel-macaque mandel-macaque approved these changes

@mauroa mauroa mauroa approved these changes

@emaf emaf emaf approved these changes

@stephen-hawley stephen-hawley stephen-hawley approved these changes

@tj-devel709 tj-devel709 tj-devel709 approved these changes

Assignees
No one assigned
Labels
bug If an issue is a bug or a pull request a bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MacOS: Testflight fails because of beta build
9 participants
@rolfbjarne @vs-mobiletools-engineering-service2 @Therzok @dalexsoto @mandel-macaque @mauroa @emaf @stephen-hawley @tj-devel709