-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[msbuild] Add DT* entries to the Info.plist for all platforms. Fixes #13300. #17499
Conversation
…xamarin/Xamarin.MacDev#13300. Modify the code to add Xcode (DT*) variables to the Info.plist: * Do it for all platforms, not only mobile platforms. Apple uses these fields to determine if an app was built with a prerelease or old version of Xcode, and will reject any app submissions if this validation fails. * Change the behavior to do not distinguish simulator builds, a bit of testing in Xcode shows that Xcode always adds these values to the Info.plist, even for simulator builds. This is probably something that changed in Xcode a *long* time ago, since this code is old (from the initial import of the build logic from MonoDevelop around 10 years ago). * Also bump Xamarin.MacDev to get a related fix: New commits in xamarin/Xamarin.MacDev: * xamarin/Xamarin.MacDev@74c95ee [Xamarin.MacDev] Always fetch the DTSDKBuild variable. Diff: https://github.com/xamarin/Xamarin.MacDev/compare/14d53612d4624459a7ae617141c45e940ada6df5..74c95ee1c345cc194a35e6f0c9400f6a55a9b617 Fixes xamarin#13300.
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes)
NET (empty diffs)
✅ API diff vs stableLegacy Xamarin (No breaking changes).NET (No breaking changes)✅ Generator diffGenerator diff is empty Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11.5) passed. Pipeline on Agent |
🔥 [CI Build] Test results 🔥Test results❌ Tests failed on VSTS: simulator tests 0 tests crashed, 1 tests failed, 224 tests passed. Failures❌ bcl tests
Html Report (VSDrops) Download Successes✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
Test failure is unrelated (https://github.com/xamarin/maccore/issues/2450). |
Modify the code to add Xcode (DT*) variables to the Info.plist:
Do it for all platforms, not only mobile platforms. Apple uses these fields to
determine if an app was built with a prerelease or old version of Xcode, and will
reject any app submissions if this validation fails.
Change the behavior to do not distinguish simulator builds, a bit of testing
in Xcode shows that Xcode always adds these values to the Info.plist, even for
simulator builds. This is probably something that changed in Xcode a long time
ago, since this code is old (from the initial import of the build logic from MonoDevelop
around 10 years ago).
Also bump Xamarin.MacDev to get a related fix:
New commits in xamarin/Xamarin.MacDev:
Diff: https://github.com/xamarin/Xamarin.MacDev/compare/14d53612d4624459a7ae617141c45e940ada6df5..74c95ee1c345cc194a35e6f0c9400f6a55a9b617
Fixes #13300.