-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[src] Refactor block code to use blittable callbacks. #17641
Conversation
This is mostly converting 'bool' arguments to 'byte' arguments, and 'string' arguments to 'IntPtr' with custom utf8->string conversions. This is necessary in order to convert all block callbacks to use UnmanagedCallersOnly function pointers (which can't have non-blittable types in their signature). Contributes towards xamarin#15783.
|
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes)
NET (empty diffs)
✅ API diff vs stableLegacy Xamarin (No breaking changes).NET (No breaking changes)✅ Generator diffGenerator diff is empty Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11.5) passed. Pipeline on Agent |
❌ [PR Build] Tests on macOS M1 - Mac Ventura (13.0) failed ❌Failed tests are:
Pipeline on Agent |
@@ -200,15 +200,15 @@ public void RequestAccess (Action<bool, NSError?> onCompleted) | |||
} | |||
} | |||
|
|||
internal delegate void InnerCompleted (IntPtr block, bool success, IntPtr error); | |||
internal delegate void InnerCompleted (IntPtr block, byte success, IntPtr error); | |||
static readonly InnerCompleted static_completionHandler = TrampolineCompletionHandler; | |||
[MonoPInvokeCallback (typeof (InnerCompleted))] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this (and the other) have [UnmanagedCallersOnly]
or are you planning to do that later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's coming later
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: simulator tests. 🎉 All 225 tests passed 🎉 Tests counts✅ bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
This is mostly converting 'bool' arguments to 'byte' arguments, and 'string'
arguments to 'IntPtr' with custom utf8->string conversions.
This is necessary in order to convert all block callbacks to use
UnmanagedCallersOnly function pointers (which can't have non-blittable types
in their signature).
Contributes towards #15783.