-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Templates] Add comments to help developers publish MacCatalyst apps on App Store #17830
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
dotnet/Templates/Microsoft.MacCatalyst.Templates/maccatalyst/csharp/Entitlements.plist
Outdated
Show resolved
Hide resolved
dotnet/Templates/Microsoft.MacCatalyst.Templates/maccatalyst/csharp/Info.plist
Outdated
Show resolved
Hide resolved
dotnet/Templates/Microsoft.MacCatalyst.Templates/maccatalyst/csharp/MacCatalystApp1.csproj
Outdated
Show resolved
Hide resolved
dotnet/Templates/Microsoft.MacCatalyst.Templates/maccatalyst/csharp/MacCatalystApp1.csproj
Outdated
Show resolved
Hide resolved
dotnet/Templates/Microsoft.MacCatalyst.Templates/maccatalyst/csharp/MacCatalystApp1.csproj
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome and looks really helpful :)
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
dotnet/Templates/Microsoft.MacCatalyst.Templates/maccatalyst/csharp/Entitlements.plist
Outdated
Show resolved
Hide resolved
dotnet/Templates/Microsoft.MacCatalyst.Templates/maccatalyst/csharp/Info.plist
Outdated
Show resolved
Hide resolved
dotnet/Templates/Microsoft.MacCatalyst.Templates/maccatalyst/csharp/Info.plist
Outdated
Show resolved
Hide resolved
dotnet/Templates/Microsoft.MacCatalyst.Templates/maccatalyst/csharp/MacCatalystApp1.csproj
Outdated
Show resolved
Hide resolved
dotnet/Templates/Microsoft.MacCatalyst.Templates/maccatalyst/csharp/MacCatalystApp1.csproj
Outdated
Show resolved
Hide resolved
dotnet/Templates/Microsoft.MacCatalyst.Templates/maccatalyst/csharp/MacCatalystApp1.csproj
Outdated
Show resolved
Hide resolved
dotnet/Templates/Microsoft.MacCatalyst.Templates/maccatalyst/csharp/MacCatalystApp1.csproj
Outdated
Show resolved
Hide resolved
dotnet/Templates/Microsoft.MacCatalyst.Templates/maccatalyst/csharp/MacCatalystApp1.csproj
Outdated
Show resolved
Hide resolved
dotnet/Templates/Microsoft.MacCatalyst.Templates/maccatalyst/csharp/MacCatalystApp1.csproj
Outdated
Show resolved
Hide resolved
dotnet/Templates/Microsoft.MacCatalyst.Templates/maccatalyst/csharp/MacCatalystApp1.csproj
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
dotnet/Templates/Microsoft.MacCatalyst.Templates/maccatalyst/csharp/Entitlements.plist
Outdated
Show resolved
Hide resolved
dotnet/Templates/Microsoft.MacCatalyst.Templates/maccatalyst/csharp/MacCatalystApp1.csproj
Outdated
Show resolved
Hide resolved
dotnet/Templates/Microsoft.MacCatalyst.Templates/maccatalyst/csharp/MacCatalystApp1.csproj
Outdated
Show resolved
Hide resolved
dotnet/Templates/Microsoft.MacCatalyst.Templates/maccatalyst/csharp/MacCatalystApp1.csproj
Outdated
Show resolved
Hide resolved
dotnet/Templates/Microsoft.MacCatalyst.Templates/maccatalyst/csharp/MacCatalystApp1.csproj
Outdated
Show resolved
Hide resolved
dotnet/Templates/Microsoft.MacCatalyst.Templates/maccatalyst/csharp/MacCatalystApp1.csproj
Outdated
Show resolved
Hide resolved
dotnet/Templates/Microsoft.MacCatalyst.Templates/maccatalyst/csharp/MacCatalystApp1.csproj
Outdated
Show resolved
Hide resolved
dotnet/Templates/Microsoft.MacCatalyst.Templates/maccatalyst/csharp/MacCatalystApp1.csproj
Outdated
Show resolved
Hide resolved
dotnet/Templates/Microsoft.MacCatalyst.Templates/maccatalyst/csharp/MacCatalystApp1.csproj
Outdated
Show resolved
Hide resolved
dotnet/Templates/Microsoft.MacCatalyst.Templates/maccatalyst/csharp/MacCatalystApp1.csproj
Outdated
Show resolved
Hide resolved
dotnet/Templates/Microsoft.MacCatalyst.Templates/maccatalyst/csharp/MacCatalystApp1.csproj
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
💻 [CI Build] Windows Integration Tests passed 💻✅ All Windows Integration Tests passed. Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11.5) passed. Pipeline on Agent |
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes)
NET (empty diffs)
✅ API diff vs stableLegacy Xamarin (No breaking changes).NET (No breaking changes)✅ Generator diffGenerator diff is empty Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻✅ All tests on macOS M1 - Mac Ventura (13.0) passed. Pipeline on Agent |
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: simulator tests. 🎉 All 225 tests passed 🎉 Tests counts✅ bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
I wanted to make a first pass at this and make sure if I'm going in the right direction or not, and whether comments are formatted correctly. I was also unsure how to exactly test this.
I based some of these modifications based on comments from the community on how they were able to publish Maui MacCatalyst apps on the App Store.
The product archive package's signature is invalid. Ensure that it is signed with your "3rd Party Mac Developer Installer" certificate.
Solved this by modifying csproj file to add<PackageSigningKey>
and some other properties based on this guide. I wasn't sure if all the fields are necessary though.The product archive is invalid. The Info.plist must contain a LSApplicationCategoryType key, whose value is the UTI for a valid category. For more details, see "Submitting your Mac apps to the App Store".
I chose a default of public.app-category.productivity and added it to info.plist.Invalid bundle. The bundle supports arm64 but not Intel-based Mac computers. Your build must include the x86_64 architecture to support Intel-based Mac computers.
I set the default to both in the csproj, and added a comment clarifying.Invalid Bundle. The key UIDeviceFamily in the app's Info.plist file contains one or more unsupported values '1'.
There was already a PR that removed the 1 value here apparently. How would we add validation to ensure that the correct value is used?App sandbox not enabled. The following executables must include the "com.apple.security.app-sandbox" entitlement with a Boolean value of true in the entitlements property list [...]
I've added two suggested entries to the Entitlements.plist, but commented them out.ITSAppUsesNonExemptEncryption
- added this field to info.plist and set it to false.Fixes #17591