-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable nullability in various places #18082
Enable nullability in various places #18082
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
New commits in xamarin/Xamarin.MacDev: * xamarin/Xamarin.MacDev@b454d45 [Xamarin.MacDev] Move compatibility nullability attributes to their own file. * xamarin/Xamarin.MacDev@bab25f5 [Xamarin.MacDev] Add a few convenience overloads to IAppleSdk. * xamarin/Xamarin.MacDev@920e87e Update UnitTests.csproj * xamarin/Xamarin.MacDev@ccc9bd4 Update Xamarin.MacDev.csproj Diff: https://github.com/xamarin/Xamarin.MacDev/compare/74c95ee1c345cc194a35e6f0c9400f6a55a9b617..b454d454a687d9aa26a382ad16f1a9361b06b074
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11.5) passed. Pipeline on Agent |
❌ [PR Build] Tests on macOS M1 - Mac Ventura (13.0) failed ❌Failed tests are:
Pipeline on Agent |
💻 [CI Build] Windows Integration Tests passed 💻✅ All Windows Integration Tests passed. Pipeline on Agent |
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes)
NET (empty diffs)
✅ API diff vs stableLegacy Xamarin (No breaking changes).NET (No breaking changes)✅ Generator diffGenerator diff is empty Pipeline on Agent |
🔥 [CI Build] Test results 🔥Test results❌ Tests failed on VSTS: simulator tests 0 tests crashed, 1 tests failed, 224 tests passed. Failures❌ monotouch tests
Html Report (VSDrops) Download Successes✅ bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
Test failure is unrelated (https://github.com/xamarin/maccore/issues/2450). |
I started fixing nullability in one place, and then it snowballed a bit and I had to fix nullability in a lot of places. Most are trivial, except for the `generate-frameworks-constants` project: I had to create a .NET version of the project in order to compile a .NET version of the tool.
I started fixing nullability in one place, and then it snowballed a bit and I had to fix nullability in a lot of places. Most are trivial, except for the `generate-frameworks-constants` project: I had to create a .NET version of the project in order to compile a .NET version of the tool.
I started fixing nullability in one place, and then it snowballed a bit and I had to fix nullability in a lot of places.
Most are trivial, except for the
generate-frameworks-constants
project: I had to create a .NET version of the project in order to compile a .NET version of the tool.