[Introspection] Fix intro skip when the properties are internal. #18613
Conversation
The issue relies in the fact that this code path was not executed when using classic because in the classic version of the SDK we added the availavility attrs both in the property, the getters and the setters. With dotnet, we only add the attr in the property. The code uses the GetProperty method which does not return internal/private properties which means that some of those properties are not correctly skipped when on dotnet. This was discovered while working on xcode 15.
💻 [CI Build] Windows Integration Tests passed 💻✅ All Windows Integration Tests passed. Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻✅ All tests on macOS M1 - Mac Ventura (13.0) passed. Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11.5) passed. Pipeline on Agent |
📚 [PR Build] Artifacts 📚Packages generatedView packagesPipeline on Agent |
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes)
NET (empty diffs)
❗ API diff vs stable (Breaking changes)Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
.NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
✅ Generator diffGenerator diff is empty Pipeline on Agent |
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: simulator tests. 🎉 All 235 tests passed 🎉 Tests counts✅ bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
The issue relies in the fact that this code path was not executed when using classic because in the classic version of the SDK we added the availavility attrs both in the property, the getters and the setters. With dotnet, we only add the attr in the property.
The code uses the GetProperty method which does not return internal/private properties which means that some of those properties are not correctly skipped when on dotnet. This was discovered while working on xcode 15.