-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dotnet] Link Mono and Xamarin statically in Mac Catalyst by default. Fixes #14686. #18619
[dotnet] Link Mono and Xamarin statically in Mac Catalyst by default. Fixes #14686. #18619
Conversation
…ixes xamarin#14686. It's possible to create a provisioning profile for Mac Catalyst that doesn't allow dylibs in the app. It seems a significant number of people run into this problem when publishing their apps, so avoid it by linking Mono and Xamarin statically by default instead. The downside is that build time might increase a little bit. An upside however is that the app size might decrese somewhat. Fixes xamarin#14686.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…yst-broken-provisioning-profile-workaround
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11.5) passed. Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻✅ All tests on macOS M1 - Mac Ventura (13.0) passed. Pipeline on Agent |
💻 [CI Build] Windows Integration Tests passed 💻✅ All Windows Integration Tests passed. Pipeline on Agent |
📚 [PR Build] Artifacts 📚Packages generatedView packagesPipeline on Agent |
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes)
NET (empty diffs)
❗ API diff vs stable (Breaking changes)Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
.NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
✅ Generator diffGenerator diff is empty Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: simulator tests. 🎉 All 235 tests passed 🎉 Tests counts✅ bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
/sudo backport release/7.0.3xx |
Backport Job to branch release/7.0.3xx Created! The magic is happening here |
Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=8501629 for more details. |
…talyst by default. Fixes #14686. (#19134) It's possible to create a provisioning profile for Mac Catalyst that doesn't allow dylibs in the app. It seems a significant number of people run into this problem when publishing their apps, so avoid it by linking Mono and Xamarin statically by default instead. The downside is that build time might increase a little bit. An upside however is that the app size might decrese somewhat. Fixes #14686. Backport of #18619 --------- Co-authored-by: Rolf Bjarne Kvinge <[email protected]>
It's possible to create a provisioning profile for Mac Catalyst that doesn't
allow dylibs in the app. It seems a significant number of people run into this
problem when publishing their apps, so avoid it by linking Mono and Xamarin
statically by default instead.
The downside is that build time might increase a little bit.
An upside however is that the app size might decrese somewhat.
Fixes #14686.