-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/7.0.3xx] [tools] Always link weakly with NewsstandKit. Fixes #18606. #18624
[release/7.0.3xx] [tools] Always link weakly with NewsstandKit. Fixes #18606. #18624
Conversation
It seems that Apple will completely remove the NewsstandKit framework from iOS 17. This poses a problem for existing apps that link with NewsstandKit: they will crash at launch. Solve this by always linking weakly with the NewsstandKit framework; this way any apps that link with it will keep working if the framework ends up being removed by Apple. Fixes xamarin#18606.
💻 [CI Build] Windows Integration Tests passed 💻✅ All Windows Integration Tests passed. Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)
✅ API diff vs stable.NET (No breaking changes)✅ Generator diffGenerator diff is empty Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11.5) passed. Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻✅ All tests on macOS M1 - Mac Ventura (13.0) passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
🔥 [CI Build] Test results 🔥Test results❌ Tests failed on VSTS: simulator tests 0 tests crashed, 1 tests failed, 44 tests passed. Failures❌ dotnettests tests [attempt 2]
Html Report (VSDrops) Download Successes
Pipeline on Agent |
Test failures are unrelated (https://github.com/xamarin/maccore/issues/2688). |
It seems that Apple will completely remove the NewsstandKit framework from iOS 17.
This poses a problem for existing apps that link with NewsstandKit: they will
crash at launch.
Solve this by always linking weakly with the NewsstandKit framework; this way
any apps that link with it will keep working if the framework ends up being
removed by Apple.
Fixes #18606.
Fixes dotnet/maui#16316.
Backport of #18621