-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[xcode15] Add support for Xcode 15 and corresponding OS versions. #18641
[xcode15] Add support for Xcode 15 and corresponding OS versions. #18641
Conversation
Fixes this warning: > clang: warning: argument unused during compilation: '-stdlib=libc++' [-Wunused-command-line-argument]
…by bumping the min watchOS version.
…bindings. The classes have been completely removed, both from the headers and Apple's documentation, so assume they want it gone and remove it ourselves as well.
The NewsstandKit framework has been completely removed, both from the headers and Apple's documentation, so assume they want it gone and remove it ourselves as well.
Xcode15 added a new liner, ld_prime which has a number of bugs up to xcode 15 beta4. We can fix this by fwd the ld64 flag to the linker which allows to use the OLD ld64 linker over ld_primer until we have a fix from apple. Refereces: Apple docs: https://developer.apple.com/forums/thread/715385 Bug: https://developer.apple.com/forums/thread/733317
…longer supported.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@@ -28,6 +28,9 @@ public class StringAttributesTests { | |||
[Test] | |||
public void SimpleValuesSet () | |||
{ | |||
if (TestRuntime.CheckXcodeVersion (15, 0)) | |||
Assert.Ignore ("Test timeouts on Xcode 15 beta 4."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have an issue to verify this later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add an issue and will link it to the master xcode15 issue
tests/common/DotNet.cs
Outdated
@@ -176,6 +176,10 @@ public static ExecutionResult Execute (string verb, string project, Dictionary<s | |||
// Work around https://github.com/dotnet/msbuild/issues/8845 | |||
args.Add ("/v:diag"); | |||
args.Add ("/consoleloggerparameters:Verbosity=Quiet"); | |||
args.Add ("/consoleloggerparameters:Verbosity=Quiet"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this argument twice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I bet is a too fast yy.
|
Ref: #18556 |
💻 [CI Build] Windows Integration Tests passed 💻✅ All Windows Integration Tests passed. Pipeline on Agent |
🔥 Failed to compare API and create generator diff 🔥 Failed to update apidiff references Pipeline on Agent |
@@ -60,6 +61,7 @@ public NSUserActivity () | |||
#if __IOS__ && !__MACCATALYST__ | |||
public partial class NSUrlConnection { | |||
// Extension from iOS5, NewsstandKit | |||
[EditorBrowsable (EditorBrowsableState.Never)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is me just being picky but why not just make all obsolete marked selectors not editor browsable? are there special cases when we would still want this obs selector visible via intellisense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some of them that are Obsoleted but not removed, that is, they are a warning that in the future they'll be removed. Others, like this ones, are obsoleted and removed by apple and so we want to make sure that users don't even know about them.
@@ -112,7 +112,9 @@ public void NavigationControllerOverride () | |||
vc.View.BackgroundColor = UIColor.Green; | |||
}; | |||
AppDelegate.PresentModalViewController (nc, 0.5); | |||
if (TestRuntime.CheckXcodeVersion (14, 0)) { | |||
if (TestRuntime.CheckXcodeVersion (15, 0)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is the explicit check for Xcode 15 necessary? wasn't the prev logic checking for the same?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look at the content of the if block ;)
💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻✅ All tests on macOS M1 - Mac Ventura (13.0) passed. Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11.5) passed. Pipeline on Agent |
📚 [PR Build] Artifacts 📚Packages generatedView packagesPipeline on Agent |
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: simulator tests. 🎉 All 237 tests passed 🎉 Tests counts✅ bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
No description provided.