-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Symbols] Add support for the new Xcode 15 Symbols framework. #18642
[Symbols] Add support for the new Xcode 15 Symbols framework. #18642
Conversation
Leaving as draft until we land the xcode15 support. But good to keep the record straight. |
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
src/symbols.cs
Outdated
interface NSSymbolEffectOptions : NSCopying, NSSecureCoding { | ||
[Static] | ||
[Export ("options")] | ||
NSSymbolEffectOptions CreateOptions (); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it sounds better if you remove Options
:
NSSymbolEffectOptions CreateOptions (); | |
NSSymbolEffectOptions Create (); |
src/symbols.cs
Outdated
|
||
[Static] | ||
[Export ("optionsWithRepeating")] | ||
NSSymbolEffectOptions CreateOptionsWithRepeating (); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same, but also removing With
:
NSSymbolEffectOptions CreateOptionsWithRepeating (); | |
NSSymbolEffectOptions CreateRepeating (); |
and the same for the other Get and Create methods here.
This matches the Swift names better (and also sounds better).
src/symbols.cs
Outdated
NSSymbolPulseEffect CreateEffect (); | ||
|
||
[Export ("effectWithByLayer")] | ||
NSSymbolPulseEffect GetEffectWithByLayer (); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are properties in Swift (https://developer.apple.com/documentation/symbols/pulsesymboleffect/4197828-bylayer)
NSSymbolPulseEffect GetEffectWithByLayer (); | |
NSSymbolPulseEffect ByLayer { get; } |
src/symbols.cs
Outdated
[Export ("effectWithByLayer")] | ||
NSSymbolBounceEffect GetEffectWithByLayer (); | ||
|
||
[Export ("effectWithWholeSymbol")] | ||
NSSymbolBounceEffect GetEffectWithWholeSymbol (); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same, these can be properties and named better.
src/symbols.cs
Outdated
NSSymbolVariableColorEffect CreateEffect (); | ||
|
||
[Export ("effectWithIterative")] | ||
NSSymbolVariableColorEffect GetEffectWithIterative (); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same, simplified and property:
NSSymbolVariableColorEffect GetEffectWithIterative (); | |
NSSymbolVariableColorEffect Iterative { get; } |
src/symbols.cs
Outdated
interface NSSymbolVariableColorEffect { | ||
[Static] | ||
[Export ("effect")] | ||
NSSymbolVariableColorEffect CreateEffect (); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NSSymbolVariableColorEffect CreateEffect (); | |
NSSymbolVariableColorEffect Create (); |
src/symbols.cs
Outdated
interface NSSymbolScaleEffect { | ||
[Static] | ||
[Export ("effect")] | ||
NSSymbolScaleEffect CreateEffect (); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NSSymbolScaleEffect CreateEffect (); | |
NSSymbolScaleEffect Create (); |
src/symbols.cs
Outdated
[Export ("effectWithByLayer")] | ||
NSSymbolScaleEffect GetEffectWithByLayer (); | ||
|
||
[Export ("effectWithWholeSymbol")] | ||
NSSymbolScaleEffect GetEffectWithWholeSymbol (); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simplified properties
src/symbols.cs
Outdated
interface NSSymbolAutomaticContentTransition { | ||
[Static] | ||
[Export ("transition")] | ||
NSSymbolAutomaticContentTransition CreateTransition (); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I stopped suggesting, they all follow the same pattern :)
…marin-macios into net8.0-xcode15-symbols
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Rolf Bjarne Kvinge <[email protected]>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Rolf Bjarne Kvinge <[email protected]>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
Co-authored-by: Alex Soto <[email protected]>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Alex Soto <[email protected]>
💻 [CI Build] Windows Integration Tests passed 💻✅ All Windows Integration Tests passed. Pipeline on Agent |
📚 [PR Build] Artifacts 📚Packages generatedView packagesPipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻✅ All tests on macOS M1 - Mac Ventura (13.0) passed. Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11.5) passed. Pipeline on Agent |
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes).NET (No breaking changes)❗ API diff vs stable (Breaking changes)Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
.NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
🔥 [CI Build] Test results 🔥Test results❌ Tests failed on VSTS: simulator tests 0 tests crashed, 2 tests failed, 235 tests passed. Failures❌ framework tests
Html Report (VSDrops) Download ❌ mononative tests
Html Report (VSDrops) Download Successes✅ bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
Failures are un related. |
d5d14f6
into
xamarin:net8.0-xcode15
No description provided.