[net8.0] Remove workarounds for SDK and runtime bugs #18830

filipnavara · 2023-08-25T10:54:55Z

Fixes #18741
Fixes #18784

…is public and not trimmed" This reverts commit 1ddcc87.

This reverts commit 959cef6.

dalexsoto · 2023-08-25T11:13:33Z

/azp run

azure-pipelines · 2023-08-25T11:13:53Z

Azure Pipelines successfully started running 1 pipeline(s).

rolfbjarne · 2023-08-28T10:14:58Z

All the managed static registrar variations are failing with:

*** Terminating app due to uncaught exception 'ObjCRuntime.RuntimeException', reason: 'Failed to marshal the Objective-C object 0x849fd78c365b08c3 (type: NSTaggedPointerString). Could not find an existing managed instance for this object, nor was it possible to create a new managed instance (because the type 'Foundation.NSString' does not have a constructor that takes one NativeHandle argument). (ObjCRuntime.RuntimeException)
    at ObjCRuntime.Runtime.MissingCtor(IntPtr ptr, IntPtr klass, Type type, MissingCtorResolution resolution, IntPtr sel, RuntimeMethodHandle method_handle)
    at ObjCRuntime.Runtime.ConstructNSObject[NSObject](IntPtr ptr, Type type, MissingCtorResolution missingCtorResolution, IntPtr sel, RuntimeMethodHandle method_handle)
    at ObjCRuntime.Runtime.ConstructNSObject[NSObject](IntPtr ptr, Type type, MissingCtorResolution missingCtorResolution)
    at ObjCRuntime.Runtime.ConstructNSObject(IntPtr ptr, IntPtr klass, MissingCtorResolution missingCtorResolution)
    at ObjCRuntime.Runtime.GetNSObject(IntPtr ptr, MissingCtorResolution missingCtorResolution, Boolean evenInFinalizerQueue)
    at ObjCRuntime.Runtime.GetNSObject(NativeHandle ptr)
    at Foundation.NSDictionary.ObjectForKey(NSObject key)
    at ObjCRuntime.Runtime.get_iOSSupportVersion()
    at UIKit.UIDevice.CheckSystemVersion(Int32 major, Int32 minor)
    at TestRuntime.CheckiOSSystemVersion(Int32 major, Int32 minor, Boolean throwIfOtherPlatform) in /Users/builder/azdo/_work/3/s/xamarin-macios/tests/common/TestRuntime.cs:line 974
    at TestRuntime.CheckXcodeVersion(Int32 major, Int32 minor, Int32 build) in /Users/builder/azdo/_work/3/s/xamarin-macios/tests/common/TestRuntime.cs:line 568
    at MonoTouchFixtures.BackgroundTasks.BGTaskSchedulerTest.RegisterTestTasks() in /Users/builder/azdo/_work/3/s/xamarin-macios/tests/monotouch-test/BackgroundTasks/BGTaskSchedulerTest.cs:line 22
    at AppDelegate.PostFinishedLaunching() in /Users/builder/azdo/_work/3/s/xamarin-macios/tests/monotouch-test/AppDelegate.cs:line 35
    at AppDelegate.FinishedLaunching(UIApplication application, NSDictionary launchOptions) in /Users/builder/azdo/_work/3/s/xamarin-macios/tests/common/AppDelegate.cs:line 45
    at AppDelegate.__Registrar_Callbacks__.callback_2_AppDelegate_FinishedLaunching(IntPtr pobj, IntPtr sel, IntPtr p0, IntPtr p1, IntPtr* exception_gchandle)

filipnavara · 2023-08-28T10:16:24Z

Apparently the dotnet/runtime fix was not ingested yet :-/

rolfbjarne · 2023-09-14T13:36:50Z

/azp run

azure-pipelines · 2023-09-14T13:37:12Z

Azure Pipelines successfully started running 1 pipeline(s).

vs-mobiletools-engineering-service2 · 2023-09-14T15:05:42Z

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-09-14T15:07:14Z

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-09-14T15:21:18Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 971fd7088b808780ad98e6cafe1b2cd97446dc26 [PR build]

vs-mobiletools-engineering-service2 · 2023-09-14T15:26:25Z

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

~~iOS~~ (no change detected)
~~tvOS~~ (no change detected)
~~watchOS~~ (no change detected)
~~macOS~~ (no change detected)

NET (empty diffs)

~~iOS~~: (empty diff detected)
~~tvOS~~: (empty diff detected)
~~MacCatalyst~~: (empty diff detected)
~~macOS~~: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 971fd7088b808780ad98e6cafe1b2cd97446dc26 [PR build]

vs-mobiletools-engineering-service2 · 2023-09-14T15:34:40Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-09-14T17:46:51Z

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 7 tests failed, 226 tests passed.

Failures

❌ monotouch tests

7 tests failed, 32 tests passed.

monotouch-test/Mac [dotnet]/Debug [dotnet]: Failed (Test run failed.
Tests run: 2775 Passed: 2687 Inconclusive: 3 Failed: 2 Ignored: 86)
monotouch-test/Mac [dotnet]/Debug (static registrar) [dotnet]: Failed (Test run failed.
Tests run: 2772 Passed: 2684 Inconclusive: 3 Failed: 2 Ignored: 86)
monotouch-test/Mac [dotnet]/Release (NativeAOT, x64) [dotnet]: Failed (Test run failed.
Tests run: 2771 Passed: 2672 Inconclusive: 3 Failed: 2 Ignored: 97)
monotouch-test/Mac [dotnet]/Release [dotnet]: Failed (Test run failed.
Tests run: 2772 Passed: 2683 Inconclusive: 3 Failed: 2 Ignored: 87)
monotouch-test/Mac [dotnet]/Release (all optimizations) [dotnet]: Failed (Test run failed.
Tests run: 2772 Passed: 2684 Inconclusive: 3 Failed: 2 Ignored: 86)
monotouch-test/Mac [dotnet]/Debug (managed static registrar) [dotnet]: Failed (Test run failed.
Tests run: 2772 Passed: 2685 Inconclusive: 3 Failed: 2 Ignored: 85)
monotouch-test/Mac [dotnet]/Release (managed static registrar, all optimizations) [dotnet]: Failed (Test run failed.
Tests run: 2772 Passed: 2684 Inconclusive: 3 Failed: 2 Ignored: 86)

Html Report (VSDrops) Download

Successes

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 6 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 971fd7088b808780ad98e6cafe1b2cd97446dc26 [PR build]

rolfbjarne · 2023-09-15T05:43:15Z

Test failures are unrelated (https://github.com/xamarin/maccore/issues/2630).

filipnavara added 3 commits August 25, 2023 11:27

Remove PublishAotUsingRuntimePack workaround

b0a35c5

Revert "Make sure the RegistrarHelper.RuntimeTypeHandleEquals method …

efeb0b7

…is public and not trimmed" This reverts commit 1ddcc87.

Revert "Add workaround for dotnet/runtime#90800"

cdd9be2

This reverts commit 959cef6.

mandel-macaque approved these changes Aug 25, 2023

View reviewed changes

This comment has been minimized.

Sign in to view

rolfbjarne added the community Community contribution ❤ label Aug 28, 2023

This was linked to issues Sep 11, 2023

NativeAOT: revert workaround for PublishAotUsingRuntimePack #18741

Closed

NativeAOT: revert workaround for dotnet/runtime#90800 #18784

Closed

Merge remote-tracking branch 'origin/net8.0' into remove-workarounds

971fd70

rolfbjarne merged commit 7f73732 into xamarin:net8.0 Sep 15, 2023
75 of 78 checks passed

This was referenced Sep 15, 2023

NativeAOT: revert workaround for dotnet/runtime#90800 #18784

Closed

NativeAOT: revert workaround for PublishAotUsingRuntimePack #18741

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[net8.0] Remove workarounds for SDK and runtime bugs #18830

[net8.0] Remove workarounds for SDK and runtime bugs #18830

filipnavara commented Aug 25, 2023

dalexsoto commented Aug 25, 2023

azure-pipelines bot commented Aug 25, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rolfbjarne commented Aug 28, 2023

filipnavara commented Aug 28, 2023 via email •

edited

Loading

rolfbjarne commented Sep 14, 2023

azure-pipelines bot commented Sep 14, 2023

vs-mobiletools-engineering-service2 commented Sep 14, 2023

vs-mobiletools-engineering-service2 commented Sep 14, 2023

vs-mobiletools-engineering-service2 commented Sep 14, 2023

vs-mobiletools-engineering-service2 commented Sep 14, 2023

vs-mobiletools-engineering-service2 commented Sep 14, 2023

vs-mobiletools-engineering-service2 commented Sep 14, 2023

rolfbjarne commented Sep 15, 2023

[net8.0] Remove workarounds for SDK and runtime bugs #18830

[net8.0] Remove workarounds for SDK and runtime bugs #18830

Conversation

filipnavara commented Aug 25, 2023

dalexsoto commented Aug 25, 2023

azure-pipelines bot commented Aug 25, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rolfbjarne commented Aug 28, 2023

filipnavara commented Aug 28, 2023 via email • edited Loading

rolfbjarne commented Sep 14, 2023

azure-pipelines bot commented Sep 14, 2023

vs-mobiletools-engineering-service2 commented Sep 14, 2023

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

vs-mobiletools-engineering-service2 commented Sep 14, 2023

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

vs-mobiletools-engineering-service2 commented Sep 14, 2023

💻 [CI Build] Windows Integration Tests passed 💻

vs-mobiletools-engineering-service2 commented Sep 14, 2023

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

vs-mobiletools-engineering-service2 commented Sep 14, 2023

📚 [PR Build] Artifacts 📚

Packages generated

vs-mobiletools-engineering-service2 commented Sep 14, 2023

🔥 [CI Build] Test results 🔥

Test results

Failures

❌ monotouch tests

Successes

rolfbjarne commented Sep 15, 2023

filipnavara commented Aug 28, 2023 via email •

edited

Loading