[xharness] Fix parsing configuration files. #19052
Conversation
When parsing configuration files, our logic works on a first-come-wins basis,
where the first time we find a variable, that's the value we get.
In the makefiles it's the opposite: the final value is the last time a
variable is set.
This means we must parse configuration files in the reverse order, otherwise this:
INCLUDE_IOS=
INCLUDE_IOS=1
will get the opposite result of what we want.
💻 [CI Build] Windows Integration Tests passed 💻✅ All Windows Integration Tests passed. Pipeline on Agent |
📚 [PR Build] Artifacts 📚Packages generatedView packagesPipeline on Agent |
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes)
NET (empty diffs)
✅ API diff vs stableLegacy Xamarin (No breaking changes).NET (No breaking changes)✅ Generator diffGenerator diff is empty Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11.5) passed. Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻✅ All tests on macOS M1 - Mac Ventura (13.0) passed. Pipeline on Agent |
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: simulator tests. 🎉 All 234 tests passed 🎉 Tests counts✅ bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
When parsing configuration files, our logic works on a first-come-wins basis,
where the first time we find a variable, that's the value we get.
In the makefiles it's the opposite: the final value is the last time a
variable is set.
This means we must parse configuration files in the reverse order, otherwise this:
will get the opposite result of what we want.